FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-124127: Make Py_REFCNT() opaque in limited C API 3.14 by vstinner · Pull Request #124128 · python/cpython · GitHub

/ cpython Public

gh-124127: Make Py_REFCNT() opaque in limited C API 3.14 - #124128

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:refcnt_opaque
Sep 24, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-124127: Make Py_REFCNT() opaque in limited C API 3.14#124128
vstinner merged 1 commit into
python:mainfrom
vstinner:refcnt_opaque

Conversation

vstinner commented Sep 16, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

vstinner requested review from a team and encukou as code owners September 16, 2024 14:23
bedevere-app Bot mentioned this pull request Sep 16, 2024
Closed

vstinner commented Sep 16, 2024

Copy link
Copy Markdown
Member Author

cc @colesbury @Fidget-Spinner @encukou

vstinner commented Sep 20, 2024

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka

vstinner commented Sep 23, 2024

Copy link
Copy Markdown
Member Author

I plan to merge this change at the end of the week, unless someone wants to review it or has concerns about it.

serhiy-storchaka approved these changes Sep 23, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

encukou approved these changes Sep 23, 2024
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1, with a nitpick on the implementation:

Comment thread Include/refcount.h
}
#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 < 0x030b0000
# define Py_REFCNT(ob) Py_REFCNT(_PyObject_CAST(ob))
#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 < 0x030b0000

encukou Sep 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This #if is now redundant, right?

vstinner Sep 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's still needed. (Correct me if I'm wrong.)

vstinner merged commit 9d344fa into python:main Sep 24, 2024
vstinner deleted the refcnt_opaque branch September 24, 2024 06:43

vstinner commented Sep 24, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for reviews.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes
serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL