FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-124130: Notes on empty string corner case of category `\B` by y5c4l3 · Pull Request #124133 · python/cpython · GitHub

/ cpython Public

gh-124130: Notes on empty string corner case of category \B - #124133

Merged
vstinner merged 1 commit into
python:mainfrom
y5c4l3:re-non-boundary
Sep 23, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-124130: Notes on empty string corner case of category \B#124133
vstinner merged 1 commit into
python:mainfrom
y5c4l3:re-non-boundary

Conversation

y5c4l3 commented Sep 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot commented Sep 16, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Sep 16, 2024
Closed
y5c4l3 changed the title gh-124130: Match empty string for regex category \B gh-124130: Match empty strings for regex category \B Sep 16, 2024
y5c4l3 force-pushed the re-non-boundary branch 2 times, most recently from 01515bd to 5dfaf17 Compare September 16, 2024 16:15
ZeroIntensity requested changes Sep 20, 2024
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is probably a breaking change, as mentioned in the original issue :(

Could you just add a documentation note with this PR?

y5c4l3 changed the title gh-124130: Match empty strings for regex category \B gh-124130: Notes on empty string corner case of category \B Sep 21, 2024

y5c4l3 commented Sep 21, 2024

Copy link
Copy Markdown
Contributor Author

Could you just add a documentation note with this PR?

Notes added. Could you label this PR with a skip news tag?

ZeroIntensity added docs Documentation in the Doc dir skip news labels Sep 21, 2024
ZeroIntensity approved these changes Sep 21, 2024
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thank you! This is pretty much all we can do about this problem.

ZeroIntensity added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 21, 2024
vstinner approved these changes Sep 21, 2024
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

picnixz reviewed Sep 22, 2024
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just check that Perl is indeed different or use another example (or drop it if you want).

Comment thread Doc/library/re.rst Outdated
Notes on empty string corner case of category \B
947bc09 
Signed-off-by: y5c4l3 <y5c4l3@proton.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
vstinner merged commit d3e79d7 into python:main Sep 23, 2024

miss-islington-app Bot commented Sep 23, 2024

Copy link
Copy Markdown

Thanks @y5c4l3 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 23, 2024
pythongh-124130: Notes on empty string corner case of category \B (p…
6c81c7f 
…ythonGH-124133)

(cherry picked from commit d3e79d7)

Co-authored-by: Y5 <124019959+y5c4l3@users.noreply.github.com>
Signed-off-by: y5c4l3 <y5c4l3@proton.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Sep 23, 2024

Copy link
Copy Markdown

GH-124328 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 23, 2024
pythongh-124130: Notes on empty string corner case of category \B (p…
2d79509 
…ythonGH-124133)

(cherry picked from commit d3e79d7)

Co-authored-by: Y5 <124019959+y5c4l3@users.noreply.github.com>
Signed-off-by: y5c4l3 <y5c4l3@proton.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 23, 2024

bedevere-app Bot commented Sep 23, 2024

Copy link
Copy Markdown

GH-124329 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 23, 2024

vstinner commented Sep 23, 2024

Copy link
Copy Markdown
Member

Merged, thanks.

vstinner pushed a commit that referenced this pull request Sep 23, 2024
[3.12] gh-124130: Notes on empty string corner case of category \B (G…
d5aafe7 
…H-124133) (#124329)

gh-124130: Notes on empty string corner case of category `\B` (GH-124133)
(cherry picked from commit d3e79d7)

Signed-off-by: y5c4l3 <y5c4l3@proton.me>
Co-authored-by: Y5 <124019959+y5c4l3@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
[3.13] gh-124130: Notes on empty string corner case of category \B (G…
5760330 
…H-124133) (#124328)

gh-124130: Notes on empty string corner case of category `\B` (GH-124133)
(cherry picked from commit d3e79d7)

Signed-off-by: y5c4l3 <y5c4l3@proton.me>
Co-authored-by: Y5 <124019959+y5c4l3@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
vstinner vstinner approved these changes
ZeroIntensity ZeroIntensity approved these changes
+1 more reviewer
rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL