| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…ythonGH-123950) (cherry picked from commit aee219f) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Brett Cannon <brett@python.org>
|
FYI, pushing this to 3.13.1. |
Sorry, something went wrong.
|
@Yhg1s good to know, is that at all open for discussion? This means that most mypyc compiled projects (like mypy and black and charset_normalizer) will be broken on 3.13.0 when they ship 3.13 mypyc-compiled wheels. |
Sorry, something went wrong.
|
Sure, it's open for discussion. Given that this showed up all the way at the tail end of the release candidate phase, I'm assuming it must not be that pressing (or it would've shown up before :). It sounds like it is pressing, and the actual change is not that complicated (although slightly more complicated than I would've liked between the release candidate and the final release). Why didn't this show up before? How are we going to make similar issues show up earlier in the future? |
Sorry, something went wrong.
|
It didn't show up before primarily because there were other issues running mypyc with 3.13 that showed up before this one. It looks like there was also a period of 3 weeks where it was known but not acted on (following #121489 (comment) ) due to a combination of classic open source volunteer time and communication issues + also I think there was some misplaced suspicion that the issue was something specific to mypyc's test suite. Timeline on mypy's side is something like:
3.12 was easier, I think we had things green before first release candidate. Some things that could help:
|
Sorry, something went wrong.
|
FWIW, we discussed this at the sprint as well, and it's clear that this should go into 3.13.0. We should try not to break mypyc (and similar users) quite so much, to make it easier for mypyc to find these issues for us in the future :) |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
(cherry picked from commit aee219f)
Co-authored-by: Petr Viktorin encukou@gmail.com
Co-authored-by: Shantanu 12621235+hauntsaninja@users.noreply.github.com
Co-authored-by: Brett Cannon brett@python.org