FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid continuous output. by terryjreedy · Pull Request #124310 · python/cpython · GitHub

/ cpython Public

gh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid continuous output. #124310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 3 commits into from
Sep 22, 2024
+7 −1
Conversation 3 Commits 3 Checks 0 Files changed 3
Merged

gh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid continuous output. #124310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
747947f
gh-112938: IDLE - revert '_idletasks' addition in outwin
terryjreedy Sep 22, 2024
150bf2e
Fix tests on mac for idletasks reversion
terryjreedy Sep 22, 2024
13e5902
blurb
terryjreedy Sep 22, 2024
File filter

Filter by extension

Filter by extension .py  (2) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 5 additions & 0 deletions Lib/idlelib/idle_test/test_outwin.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"Test outwin, coverage 76%."

from idlelib import outwin
import sys
import unittest
from test.support import requires
from tkinter import Tk, Text
Expand All @@ -18,6 +19,10 @@ def setUpClass(cls):
root.withdraw()
w = cls.window = outwin.OutputWindow(None, None, None, root)
cls.text = w.text = Text(root)
if sys.platform == 'darwin': # Issue 112938
cls.text.update = cls.text.update_idletasks
# Without this, test write, writelines, and goto... fail.
# The reasons and why macOS-specific are unclear.

@classmethod
def tearDownClass(cls):
Expand Down
2 changes: 1 addition & 1 deletion Lib/idlelib/outwin.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def write(self, s, tags=(), mark="insert"):
assert isinstance(s, str)
self.text.insert(mark, s, tags)
self.text.see(mark)
self.text.update_idletasks()
self.text.update()
return len(s)

def writelines(self, lines):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2024-09-21-23-12-18.gh-issue-112938.OeiDru.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix uninteruptable hang when Shell gets rapid continuous output.
Back | FazBrowse Home | New Git URL