FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-124309: Fix the AssertionError when using the happy_eyeballs_delay argument in open_connection by rruuaanng · Pull Request #124311 · python/cpython · GitHub

/ cpython Public

gh-124309: Fix the AssertionError when using the happy_eyeballs_delay argument in open_connection - #124311

Closed
rruuaanng wants to merge 2 commits into
python:mainfrom
rruuaanng:gh124309
ConversationCommits (2)ChecksFiles changed
Closed

gh-124309: Fix the AssertionError when using the happy_eyeballs_delay argument in open_connection#124311
rruuaanng wants to merge 2 commits into
python:mainfrom
rruuaanng:gh124309

Conversation

rruuaanng commented Sep 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm looking for a better solution for this, if anyone finds one I can close this PR.

bedevere-app Bot commented Sep 22, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Sep 22, 2024
Closed
rruuaanng changed the title gh-124309: Fix the exception when using the happy_eyeballs_delay parameter in open_connection gh-124309: Fix the exception when using the happy_eyeballs_delay argument in open_connection Sep 22, 2024
rruuaanng changed the title gh-124309: Fix the exception when using the happy_eyeballs_delay argument in open_connection gh-124309: Fix the AssertionError when using the happy_eyeballs_delay argument in open_connection Sep 22, 2024

Wulian233 commented Sep 22, 2024

Copy link
Copy Markdown
Contributor

This change seems incorrect

1 test failed:
test.test_asyncio.test_staggered

rruuaanng commented Sep 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This change seems incorrect

1 test failed: test.test_asyncio.test_staggered

I know, I'll take up this PR and look for a solution.

rruuaanng closed this Sep 22, 2024
rruuaanng reopened this Sep 22, 2024

bedevere-app Bot commented Sep 22, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot commented Sep 22, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

rruuaanng commented Sep 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hmm, ok I give up, it seems this can only be tested on my computer.

PS E:\code\cc\cpython\alpha\cpython-main\Lib\test\test_asyncio> ../../../python.bat -m unittest discover
Running Release|x64 interpreter...
.....................................................................s........s............s.................................................................................ss.....................s.......sssssss.s.sssss......ss........s.......ssssss.ss.....................s.......sssssss...ss........ss..ssss..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................sss.s....ss...............s.s..s................s..s..........s....sssss........s.....s........s...s.....................................................................................sss...............................s............................s.......s........s.............................................................................................................................................................................................................................................................................................................................................................s............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................s....................................
----------------------------------------------------------------------
Ran 2224 tests in 111.233s

OK (skipped=76)

I apologize for opening the PR again.

rruuaanng closed this Sep 22, 2024
rruuaanng deleted the gh124309 branch November 6, 2024 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
gvanrossum Awaiting requested review from gvanrossum
kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL