| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
On my Windows computer, there's no pwsh.exe - PowerShell is powershell.exe. So I'm not sure if your change should be applied as is - perhaps have powershell.exe or pwsh.exe replace PowerShell? |
Sorry, something went wrong.
I have both -- pwsh.exe is PowerShell 7 and powershell.exe is PowerShell 5 (Windows PowerShell). This appears to be official. A |
Sorry, something went wrong.
There was a problem hiding this comment.
The change for POSIX seems fine but per Vinay's note the Windows entry should read either "PowerShell" or indicate that both powershell.exe and pwsh.exe are supported.
A
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
unless something like the following is workable, I'll revert to the string PowerShell, and perform a soft reset please clarify Member preference Doc/library/venv.rst .. versionadded:: 3.8
PowerShell activation scripts installed under POSIX for PowerShell Core
- support.
+ support (users of PowerShell 5.1 replace pwsh.exe with powershell.exe in
+ the table). |
Sorry, something went wrong.
|
if neither the herein nor last comment's ideas are workable, I'll revert to the string PowerShell and perform a soft reset in the last comment it was suggested the text in .. versionadded:: 3.8 could be supplemented a different approach might be adding a Note: directly after the text of .. versionadded:: 3.8 support.
+ .. note::
+ Users of PowerShell 5.1 replace pwsh.exe with powershell.exe in
+ the table.
+
You don't specifically *need* to activate a virtual environment, |
Sorry, something went wrong.
I was disinclined to widen the table's second column. Lib/venv/scripts/common/activate CPython and PyPI packages' docs would be simpler if the bash/zsh script was named activate.sh. python -m venv venv Then it could be coded that resultant of the above command venv/bin/activate.sh was copied to venv/bin/activate. That could remain in the code for some years until a notification was made on file copying deprecation. regarding documentation simplification At minimum then is a packager notice to the user to source or run the appropriate script for their preferred command-line shell. |
Sorry, something went wrong.
(cherry picked from commit 7f93dbf) Co-authored-by: musvaage <112724366+musvaage@users.noreply.github.com> Co-authored-by: musvaage <musvaage@users.noreply.github.com>
(cherry picked from commit 7f93dbf) Co-authored-by: musvaage <112724366+musvaage@users.noreply.github.com> Co-authored-by: musvaage <musvaage@users.noreply.github.com>
|
GH-125171 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
|
GH-125172 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Co-authored-by: musvaage <musvaage@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
changes PowerShell to pwsh and pwsh.exe
changes POSIX PowerShell to pwsh
📚 Documentation preview 📚: https://cpython-previews--124315.org.readthedocs.build/