FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119180: Add discussion of annotations to the 3.14 What's New by JelleZijlstra · Pull Request #124393 · python/cpython · GitHub

/ cpython Public

gh-119180: Add discussion of annotations to the 3.14 What's New - #124393

Merged
JelleZijlstra merged 5 commits into
python:mainfrom
JelleZijlstra:pep649-whatsnew
Sep 24, 2024
Merged

gh-119180: Add discussion of annotations to the 3.14 What's New#124393
JelleZijlstra merged 5 commits into
python:mainfrom
JelleZijlstra:pep649-whatsnew

Conversation

JelleZijlstra commented Sep 23, 2024
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added awaiting core review docs Documentation in the Doc dir skip news labels Sep 23, 2024
bedevere-app Bot mentioned this pull request Sep 23, 2024
30 tasks

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice!

Comment thread Doc/whatsnew/3.14.rst
Comment on lines +84 to +88
annotations. Annotations may be evaluated in the :attr:`~annotationlib.Format.VALUE`
format (which evaluates annotations to runtime values, similar to the behavior in
earlier Python versions), the :attr:`~annotationlib.Format.FORWARDREF` format
(which replaces undefined names with special markers), and the
:attr:`~annotationlib.Format.SOURCE` format (which returns annotations as strings).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These will render as VALUE, FORWARDREF, SOURCE. Is that what we want, or would Format.VALUE, Format.FORWARDREF and Format.SOURCE be better?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I did intend these to render as VALUE etc. Do you think adding Format is better?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think I'd weakly prefer Format.VALUE, but it might make the markup quite verbose, and I don't have a strong opinion :-)

Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Doc/whatsnew/3.14.rst
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
JelleZijlstra and others added 2 commits September 23, 2024 17:16
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

Copy link
Copy Markdown
Member

(As I mentioned offline, my high-level feedback would be that it would be nice to have some more positive content about the motivations and advantages of this change. Overall the tone is a bit gloomy currently -- but it's overall a great change, that we have lots of reasons for! :-D )

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

JelleZijlstra merged commit d56faf2 into python:main Sep 24, 2024
JelleZijlstra deleted the pep649-whatsnew branch September 24, 2024 05:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL