Repository navigation
gh-119333: PyContext watchers notify get interp from tstate - #124444
Merged
kumaraditya303 merged 3 commits intoSep 26, 2024
Merged
kumaraditya303 merged 3 commits into
kumaraditya303 merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@kumaraditya303 Is this better? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Need a "skip news" label since the last pull had the news this is just a fix |
Sorry, something went wrong.
Comment thread
Python/context.c
Outdated
kumaraditya303
approved these changes
Sep 26, 2024
kumaraditya303
enabled auto-merge (squash)
September 26, 2024 05:03
gvanrossum
approved these changes
Sep 26, 2024
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'll merge now that Kumar approved.
Thanks for the updated PR!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a suggestion from #119335 that we should be getting the *interp from tstate instead.
Also attempting to clean up comments as suggested.