FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix registry key for windows sdk detection by isuruf · Pull Request #12445 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Fix registry key for windows sdk detection - #12445

Merged
zooba merged 1 commit into
python:masterfrom
isuruf:patch-2
Mar 21, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Fix registry key for windows sdk detection#12445
zooba merged 1 commit into
python:masterfrom
isuruf:patch-2

Conversation

isuruf commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

Was broken by #4298

I don't think there's a need for an issue, but I can make one if you want.

isuruf requested a review from a team as a code owner March 19, 2019 17:49

the-knights-who-say-ni commented Mar 19, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

zooba commented Mar 21, 2019

Copy link
Copy Markdown
Member

Thanks for the fix!

zooba merged commit aedc273 into python:master Mar 21, 2019

miss-islington commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Thanks @isuruf for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Thanks @isuruf for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Thanks @isuruf for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Sorry, @isuruf and @zooba, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker aedc273fd90e31c7a20904568de3115f8957395b 3.6

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2019
Fix registry key for Windows SDK detection (pythonGH-12445)
98c71b2 
(cherry picked from commit aedc273)

Co-authored-by: Isuru Fernando <isuruf@gmail.com>

bedevere-bot commented Mar 21, 2019

Copy link
Copy Markdown

GH-12487 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Mar 21, 2019
Fix registry key for Windows SDK detection (GH-12445)
cba5ddf 
(cherry picked from commit aedc273)

Co-authored-by: Isuru Fernando <isuruf@gmail.com>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Mar 25, 2019
Fix registry key for Windows SDK detection (pythonGH-12445)
3ee1266 
(cherry picked from commit aedc273)

Co-authored-by: Isuru Fernando <isuruf@gmail.com>
jjhelmus added a commit to regro-cf-autotick-bot/python-feedstock that referenced this pull request Mar 27, 2019
Drop gh12445.patch
9eea625 
Patch is un-needed as change was merged upstream, see python/cpython#12445
isuruf deleted the patch-2 branch April 5, 2019 14:15
mingwandroid pushed a commit to AnacondaRecipes/python-feedstock that referenced this pull request Dec 30, 2019
Drop gh12445.patch
198f984 
Patch is un-needed as change was merged upstream, see python/cpython#12445
deletedcu pushed a commit to deletedcu/python-feedstock that referenced this pull request Jul 20, 2021
Drop gh12445.patch
a2d2feb 
Patch is un-needed as change was merged upstream, see python/cpython#12445
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

zooba

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL