[3.12] gh-116510: Fix crash during sub-interpreter shutdown - #124536
Merged
nascheme merged 1 commit intoSep 27, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fix a bug that can cause a crash when sub-interpreters use "basic" single-phase extension modules. Shared objects could refer to PyGC_Head nodes that had been freed as part of interpreter shutdown.
Copy link
Copy Markdown
Member
Author
|
My fix for this issue is more minimal compared to what was done in gh-30577 (and accidentally reverted in gh-94673). The original fix untracks all GC objects and increfs them. I think that's more than required. We just need to make sure none of them refer to the GC head nodes that we are going to free. At least, I think that's enough and it fixes the weechat crash. Need to check the Kodi crash too. |
Sorry, something went wrong.
ericsnowcurrently
approved these changes
Sep 26, 2024
ericsnowcurrently
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug that can cause a crash when sub-interpreters use "basic" single-phase extension modules. Shared objects could refer to PyGC_Head nodes that had been freed as part of interpreter shutdown.