FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-124538: Fix crash when using `gc.get_referents` on an untracked capsule object by ZeroIntensity · Pull Request #124559 · python/cpython · GitHub

/ cpython Public

gh-124538: Fix crash when using gc.get_referents on an untracked capsule object - #124559

Merged
vstinner merged 4 commits into
python:mainfrom
ZeroIntensity:fix-capsule-traverse
Sep 26, 2024
ConversationCommits (4)ChecksFiles changed
Merged

gh-124538: Fix crash when using gc.get_referents on an untracked capsule object#124559
vstinner merged 4 commits into
python:mainfrom
ZeroIntensity:fix-capsule-traverse

Conversation

ZeroIntensity commented Sep 25, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Sep 25, 2024
Closed
Yhg1s added the needs backport to 3.13 bugs and security fixes label Sep 25, 2024
JelleZijlstra approved these changes Sep 26, 2024
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

cc @vstinner who implemented this in #108417.

vstinner approved these changes Sep 26, 2024
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Lib/test/test_gc.py Outdated

@cpython_only
def test_get_referents_on_capsule(self):
# See GH-124538

vstinner Sep 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would you mind to elaborate?

vstinner reviewed Sep 26, 2024
View reviewed changes
Comment thread Lib/test/test_gc.py Outdated
Update test_gc.py
e8b7e47 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner merged commit f923605 into python:main Sep 26, 2024

miss-islington-app Bot commented Sep 26, 2024

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2024
pythongh-124538: Fix crash when using gc.get_referents on an untrac…
bf79314 
…ked capsule object (pythonGH-124559)

(cherry picked from commit f923605)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

bedevere-app Bot commented Sep 26, 2024

Copy link
Copy Markdown

GH-124588 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 26, 2024

vstinner commented Sep 26, 2024

Copy link
Copy Markdown
Member

Merged, thanks.

Yhg1s pushed a commit that referenced this pull request Sep 26, 2024
[3.13] gh-124538: Fix crash when using gc.get_referents on an untra…
22dee7b 
…cked capsule object (GH-124559) (#124588)

gh-124538: Fix crash when using `gc.get_referents` on an untracked capsule object (GH-124559)
(cherry picked from commit f923605)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity deleted the fix-capsule-traverse branch October 24, 2024 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL