FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-124309: Modernize the `staggered_race` implementation to support eager task factories (GH-124390) by miss-islington · Pull Request #124573 · python/cpython · GitHub

/ cpython Public

[3.13] gh-124309: Modernize the staggered_race implementation to support eager task factories (GH-124390) - #124573

Closed
miss-islington wants to merge 3 commits into
python:3.13from
miss-islington:backport-de929f3-3.13
ConversationCommits (3)ChecksFiles changed
Closed

[3.13] gh-124309: Modernize the staggered_race implementation to support eager task factories (GH-124390)#124573
miss-islington wants to merge 3 commits into
python:3.13from
miss-islington:backport-de929f3-3.13

Conversation

miss-islington commented Sep 26, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit de929f3)

Co-authored-by: Peter Bierma zintensitydev@gmail.com
Co-authored-by: Thomas Grainger tagrain@gmail.com
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
Co-authored-by: Carol Willing carolcode@willingconsulting.com
Co-authored-by: Kumar Aditya kumaraditya@python.org

pythongh-124309: Modernize the staggered_race implementation to sup…
b7cb6e8 
…port eager task factories (pythonGH-124390)

(cherry picked from commit de929f3)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
This was referenced Sep 26, 2024
Merged
Closed

Yhg1s commented Sep 26, 2024

Copy link
Copy Markdown
Member

Does this need to go into 3.13.0, or can it wait until 3.13.1?

This was referenced Sep 26, 2024
Closed
Merged
gvanrossum mentioned this pull request Sep 28, 2024
Merged

kumaraditya303 commented Sep 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Does this need to go into 3.13.0, or can it wait until 3.13.1?

would be good to have in 3.13.0 as loop param is now added back.

gvanrossum approved these changes Sep 29, 2024
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, two optional nits.

I'll leave it to @Yhg1s to decide whether to include this in RC3.

Comment thread Lib/asyncio/base_events.py Outdated
exceptions, addrinfo, laddr_infos)
for addrinfo in infos),
happy_eyeballs_delay, loop=self)
happy_eyeballs_delay)

gvanrossum Sep 29, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No need to change this now?

kumaraditya303 Sep 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I added it back but I don't think it's necessary, loop would be the running loop anyways at this point.

Comment thread Lib/asyncio/staggered.py
gvanrossum requested a review from Yhg1s September 30, 2024 15:14
Yhg1s reviewed Oct 24, 2024
View reviewed changes

Yhg1s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this in a state to go in now? (The branch needs updating, and I don't know if there's been any other work in main that should be reflected in this change.)

graingert commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

This original PR was reverted, and this backport is no longer needed

graingert closed this Oct 31, 2024
miss-islington deleted the backport-de929f3-3.13 branch January 2, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Yhg1s Yhg1s left review comments
kumaraditya303 kumaraditya303 approved these changes
gvanrossum gvanrossum approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

awaiting merge topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL