gh-118658: Modify cert generation script to extract cert3.pem - #124599
Closed
felixfontein wants to merge 1 commit into
Closed
gh-118658: Modify cert generation script to extract cert3.pem#124599felixfontein wants to merge 1 commit into
felixfontein wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Sep 26, 2024
Copy link
Copy Markdown
Contributor
Author
Apparently it does: ERROR: test_certificate_chain (test.test_ssl.TestPostHandshakeAuth.test_certificate_chain)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/cpython/cpython/Lib/test/test_ssl.py", line 4707, in test_certificate_chain
expected_ee_cert = ssl.PEM_cert_to_DER_cert(f.read())
File "/home/runner/work/cpython/cpython/Lib/ssl.py", line 1498, in PEM_cert_to_DER_cert
raise ValueError("Invalid PEM encoding; must start with %s"
% PEM_HEADER)
ValueError: Invalid PEM encoding; must start with -----BEGIN CERTIFICATE-----
So PEM_cert_to_DER_cert doesn't like PEM with comments. I guess in that case #124598 is preferable. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #124598 that's simpler. The additional data in cert3.pem shouldn't affect the tests.
Edit: doesn't work since PEM_cert_to_DER_cert doesn't like PEM comments.