gh-124606: Fix reference leak in error path in datetime_fromisoformat in _datetimemodule.c - #124607
Merged
Eclips4 merged 1 commit intoSep 26, 2024
Merged
gh-124606: Fix reference leak in error path in datetime_fromisoformat in _datetimemodule.c#124607Eclips4 merged 1 commit into
Eclips4 merged 1 commit into
Conversation
picnixz
approved these changes
Sep 26, 2024
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you for the fix! (though I find the gotos a bit too hard to follow in this specific function). Do you want to run the refleak build bots?
Sorry, something went wrong.
vstinner
approved these changes
Sep 26, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
I confirm that ./python -m test test_datetime -R 3:3 no longer leaks with this change.
For the PR title, you may refer to datetime_fromisoformat() which is more precise ;-)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
It's not needed. I tested manually. |
Sorry, something went wrong.
Eclips4
enabled auto-merge (squash)
September 26, 2024 15:18
Eclips4
disabled auto-merge
September 26, 2024 15:23
Eclips4
enabled auto-merge (squash)
September 26, 2024 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.