Repository navigation
GH-124547: Clear instance dictionary if memory error occurs during object dealloc - #124627
Merged
markshannon merged 2 commits intoSep 27, 2024
Merged
markshannon merged 2 commits into
markshannon merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…into the dict when deallocating the object
DinoV
approved these changes
Sep 27, 2024
DinoV
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 27, 2024
…ing object dealloc (pythonGH-124627) (cherry picked from commit 0e21cc6) Co-authored-by: Mark Shannon <mark@hotpy.org>
Copy link
Copy Markdown
|
GH-124714 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a memory error occurs when copying values into the dict during object deallocation: clear the dict, so that the dict is at least a valid object.