gh-107954: Fix configuration type for the perf profiler - #124636
Merged
ambv merged 3 commits intoSep 27, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
|
@pablogsal thanks! I confirm that this PR fixes #124613 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tests are failing, I think they need to be updated as well. ======================================================================
FAIL: test_config_get (test.test_capi.test_config.CAPITests.test_config_get) (name='perf_profiling', option_type=<class 'bool'>, sys_attr=None)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/admin/actions-runner/_work/cpython/cpython/Lib/test/test_capi/test_config.py", line 130, in test_config_get
self.assertIsInstance(value, option_type)
~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 is not an instance of <class 'bool'>
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@pablogsal: I pushed a change in your PR to update tests. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I didn't know that perf_profiling can have two values, 1 or 2. It's not documented. @pablogsal: I also pushed a change to complete the doc and add more tests. Would you mind to review my change? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks folks, I've tested the PR in our internal CI and all the tests are passing. LGTM. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.