FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-124487: Require at least Windows 10 SDK and for install by zooba · Pull Request #124672 · python/cpython · GitHub

/ cpython Public

gh-124487: Require at least Windows 10 SDK and for install - #124672

Merged
zooba merged 5 commits into
python:mainfrom
zooba:gh-124487
Sep 30, 2024
ConversationCommits (5)ChecksFiles changed
Merged

gh-124487: Require at least Windows 10 SDK and for install#124672
zooba merged 5 commits into
python:mainfrom
zooba:gh-124487

Conversation

zooba commented Sep 27, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

zooba requested a review from a team as a code owner September 27, 2024 14:08
bedevere-app Bot mentioned this pull request Sep 27, 2024
Closed
zooba added the needs backport to 3.13 bugs and security fixes label Sep 27, 2024

zooba commented Sep 27, 2024

Copy link
Copy Markdown
Member Author

#124676 is an alternative fix that might be considered for 3.13 instead of this one.

zooba removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
Wulian233 reviewed Sep 28, 2024
View reviewed changes

Wulian233 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is the minimum installation requirement for PR now Win10? If yes, I think the FailureOldOS information needs to be changed as well

https://github.com/search?q=repo%3Apython%2Fcpython%20FailureOldOS&type=code

At least Windows 8.1 or Windows Server 2012 are required to install

Comment thread PC/pyconfig.h.in Outdated
Wulian233 mentioned this pull request Sep 30, 2024
Merged
zooba and others added 2 commits September 30, 2024 16:46
Update PC/pyconfig.h.in
2a28de2 
Co-authored-by: Wulian <1055917385@qq.com>
Update installer string
adc9850

zooba commented Sep 30, 2024

Copy link
Copy Markdown
Member Author

Thanks for the review! Good catches

zooba merged commit fac5e7a into python:main Sep 30, 2024
zooba deleted the gh-124487 branch September 30, 2024 17:50
Wulian233 mentioned this pull request Oct 1, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Wulian233 Wulian233 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL