gh-124613: Don't run perf tests in JIT builds - #124792
Merged
pablogsal merged 2 commits intoSep 30, 2024
Merged
Conversation
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal
force-pushed
the
gh-124613
branch
from
14e6f79 to
3e7ccf0
Compare
September 30, 2024 17:07
vstinner
approved these changes
Sep 30, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. I just suggested some minor changes.
Sorry, something went wrong.
Comment thread
Lib/test/test_perf_profiler.py
Outdated
Comment thread
Lib/test/test_perf_profiler.py
Outdated
Co-authored-by: Victor Stinner <vstinner@python.org>
pablogsal
force-pushed
the
gh-124613
branch
from
7d251d4 to
851f12c
Compare
September 30, 2024 17:24
pablogsal
enabled auto-merge (squash)
September 30, 2024 17:30
Copy link
Copy Markdown
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 35541c410d894d4fa18002f7fdbebfe522f8320e 3.13 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
If we don't want to skip these on most builds, we could decorate the tests with test.support.without_optimizer. See #124794 (comment). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.