[3.12] gh-124785: Revert "gh-116510: Fix crash due to shared immortal interned strings (gh-124646)" (gh-124807) - #124818
[3.12] gh-124785: Revert "gh-116510: Fix crash due to shared immortal interned strings (gh-124646)" (gh-124807)#124818Yhg1s wants to merge 1 commit into
Conversation
Sorry, something went wrong.
…red immortal interned strings (pythongh-124646)" (pythongh-124807) Revert "pythongh-116510: Fix crash due to shared immortal interned strings. (pythongh-124646)" This reverts commit 98b2ed7. (cherry picked from commit 7bdfabe) Co-authored-by: T. Wouters <thomas@python.org>
| if (interned == NULL) { | ||
| return -1; | ||
| } | ||
| PyObject *interned = interned = PyDict_New(); |
There was a problem hiding this comment.
Why do you want to do this? Rather than
PyObject *interned = PyDict_New();
Sorry, something went wrong.
There was a problem hiding this comment.
It's just a straight reversion of my change so that matches the previous code. I agree with you though, looks odd to write it that way.
Sorry, something went wrong.
There was a problem hiding this comment.
It's a revert. Even worse, it's a backport of a revert. That's what the original code was. I imagine it was a mistake in the original PR (#102339) but that, too, may have been moved from somewhere else.
If you want to send a PR to fix it (in main) I'm sure Eric wouldn't mind reviewing :)
Sorry, something went wrong.
Revert "gh-116510: Fix crash due to shared immortal interned strings. (gh-124646)"
This reverts commit 98b2ed7.
(cherry picked from commit 7bdfabe)