gh-123961: convert curses.window static type into a heap type - #124934
Merged
vstinner merged 9 commits intoOct 4, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Eclips4
self-requested a review
October 3, 2024 14:00
vstinner
reviewed
Oct 3, 2024
vstinner
reviewed
Oct 3, 2024
Comment thread
Modules/_cursesmodule.c
Outdated
vstinner
approved these changes
Oct 3, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Since I'm waiting for Kirill's review, I'll also run the build bots! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
There is no ref leak: $ ./python -m test test_curses -u all -R 3:3 (...) Result: SUCCESS |
Sorry, something went wrong.
Eclips4
reviewed
Oct 3, 2024
Comment thread
Misc/NEWS.d/next/C_API/2024-10-03-14-06-08.gh-issue-123961.uwJQTY.rst
Outdated
We also remove the use of a the `file` role since we incorrectly used it :')
Eclips4
approved these changes
Oct 3, 2024
Eclips4
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. 🚀
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merged, thanks. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should do the job. I observed that there are more reference leaks but I think it's normal since I don't know of any way to actually clear the heap type in a single-phase initialization module.
The only way I can think of clearing it is to add some finalization callback at interpreter's shutdown but I think this is not a good idea because we'll likely transform the module into a multi-phase initialization module in the next PR.
However, I'd like to have some additional eyes (cc @encukou @Eclips4) to indeed check that the reference leaks that I introduced are inevitable and not due to how I defined the heap type.
📚 Documentation preview 📚: https://cpython-previews--124934.org.readthedocs.build/