FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-123378: fix a crash in `UnicodeError.__str__` by picnixz · Pull Request #124935 · python/cpython · GitHub

/ cpython Public

gh-123378: fix a crash in UnicodeError.__str__ - #124935

Merged
vstinner merged 11 commits into
python:mainfrom
picnixz:fix/unicode-error-str-123378
Oct 8, 2024
ConversationCommits (11)ChecksFiles changed
Merged

gh-123378: fix a crash in UnicodeError.__str__#124935
vstinner merged 11 commits into
python:mainfrom
picnixz:fix/unicode-error-str-123378

Conversation

picnixz commented Oct 3, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

picnixz requested a review from iritkatriel as a code owner October 3, 2024 12:51
bedevere-app Bot mentioned this pull request Oct 3, 2024
Closed
picnixz mentioned this pull request Oct 3, 2024
Merged
encukou reviewed Oct 4, 2024
View reviewed changes
Comment thread Objects/exceptions.c
picnixz changed the title gh-123378: fix a crash in Unicode{Encode,Decode}Error.__str__ gh-123378: fix a crash in UnicodeError.__str__ Oct 4, 2024
picnixz force-pushed the fix/unicode-error-str-123378 branch from 5ca7f92 to 360c1a5 Compare October 5, 2024 10:28
picnixz requested a review from encukou October 5, 2024 10:37
encukou approved these changes Oct 7, 2024
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good, thank you!

picnixz requested a review from encukou October 7, 2024 14:40
vstinner reviewed Oct 7, 2024
View reviewed changes
Comment thread Lib/test/test_exceptions.py Outdated

def test_unicode_error_str_gh_123378(self):
for formatter, start, end, obj in product(
(str, repr),

vstinner Oct 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Testing repr() if we already test str() sounds redundant to me. Is it really worth it?

picnixz Oct 8, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No you're right. I'll remove it.

Comment thread Lib/test/test_exceptions.py Outdated
for klass in klasses:
self.assertEqual(str(klass.__new__(klass)), "")

def test_unicode_error_str_gh_123378(self):

vstinner Oct 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The purpose of the test is unclear to me, it just calls str(). Please add a comment to explain that you check that str() doesn't crash with a reference to the issue.

Comment thread Lib/test/test_exceptions.py Outdated
(str, repr),
range(-5, 5),
range(-5, 5),
('', 'a', '123', '1234', '12345', 'abc123'),

vstinner Oct 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
('', 'a', '123', '1234', '12345', 'abc123'),
('', 'a', 'abc', 'abcde', 'abcdef'),

picnixz requested a review from vstinner October 8, 2024 09:07
vstinner merged commit ba14dfa into python:main Oct 8, 2024
vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 8, 2024

miss-islington-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2024
pythongh-123378: fix a crash in UnicodeError.__str__ (pythonGH-124935)
f1a3817 
(cherry picked from commit ba14dfa)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2024
pythongh-123378: fix a crash in UnicodeError.__str__ (pythonGH-124935)
b928a8b 
(cherry picked from commit ba14dfa)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

GH-125098 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 8, 2024

bedevere-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

GH-125099 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 8, 2024
picnixz deleted the fix/unicode-error-str-123378 branch October 8, 2024 11:50
vstinner pushed a commit that referenced this pull request Oct 8, 2024
[3.12] gh-123378: fix a crash in UnicodeError.__str__ (GH-124935) (#…
d3b437c 
…125098)

gh-123378: fix a crash in `UnicodeError.__str__` (GH-124935)
(cherry picked from commit ba14dfa)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Oct 8, 2024
[3.13] gh-123378: fix a crash in UnicodeError.__str__ (GH-124935) (#…
8499115 
…125099)

gh-123378: fix a crash in `UnicodeError.__str__` (GH-124935)
(cherry picked from commit ba14dfa)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this pull request Oct 9, 2024
pythongh-123378: fix a crash in UnicodeError.__str__ (python#124935)
0056888
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
encukou Awaiting requested review from encukou
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL