FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-121970: Extract ``availability`` into a new extension by AA-Turner · Pull Request #125082 · python/cpython · GitHub

/ cpython Public

GH-121970: Extract availability into a new extension - #125082

Merged
AA-Turner merged 4 commits into
python:mainfrom
AA-Turner:docs/availability
Oct 9, 2024
ConversationCommits (4)ChecksFiles changed
Merged

GH-121970: Extract availability into a new extension#125082
AA-Turner merged 4 commits into
python:mainfrom
AA-Turner:docs/availability

Conversation

AA-Turner commented Oct 8, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This gives identical output before-and-after with SOURCE_DATE_EPOCH.

A

📚 Documentation preview 📚: https://cpython-previews--125082.org.readthedocs.build/

AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 8, 2024
bedevere-app Bot mentioned this pull request Oct 8, 2024
Open

hugovk commented Oct 8, 2024

Copy link
Copy Markdown
Member

Is the point here that it's easier to reason about as a standalone extension, rather than everything being in one big pyspecific.py file?

AA-Turner commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

Indeed, and also allows for more gradual improvement towards type hints & linting.

We already had a patchy approach with some standalone extensions and a massive pyspecific file, the intended end goal is that each extension is self contained.

pyspecific will probably remain, but will just contain the monkey-patches we apply to Sphinx/Docutils.

A

hugovk reviewed Oct 8, 2024
View reviewed changes
Comment thread Doc/tools/extensions/availability.py
AA-Turner requested a review from hugovk October 9, 2024 06:42
hugovk reviewed Oct 9, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's stick with the (mostly) double quotes from the original (and change the couple of singles into double).

PEP 8 says "In Python, single-quoted strings and double-quoted strings are the same. This PEP does not make a recommendation for this. Pick a rule and stick to it."

AA-Turner requested a review from hugovk October 9, 2024 20:14
hugovk approved these changes Oct 9, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

AA-Turner merged commit cbfd392 into python:main Oct 9, 2024
AA-Turner deleted the docs/availability branch October 9, 2024 20:50

miss-islington-app Bot commented Oct 9, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Oct 9, 2024

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cbfd39247983309a9ef0ae6da6c61cc71665b967 3.13

miss-islington-app Bot commented Oct 9, 2024

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cbfd39247983309a9ef0ae6da6c61cc71665b967 3.12

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Oct 10, 2024
[3.13] pythonGH-121970: Extract availability into a new extension (…
3f403f0 
…pythonGH-125082)

(cherry picked from commit cbfd392)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Oct 10, 2024

Copy link
Copy Markdown

GH-125237 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 10, 2024
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Oct 10, 2024
[3.12] pythonGH-121970: Extract availability into a new extension (…
b688709 
…pythonGH-125082)

(cherry picked from commit cbfd392)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Oct 10, 2024

Copy link
Copy Markdown

GH-125238 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 10, 2024
AA-Turner added a commit that referenced this pull request Oct 10, 2024
[3.12] GH-121970: Extract availability into a new extension (GH-1…
caa4924 
…25082) (#125238)

(cherry picked from commit cbfd392)
AA-Turner added a commit that referenced this pull request Oct 10, 2024
[3.13] GH-121970: Extract availability into a new extension (GH-1…
abb01fd 
…25082) (#125237)

(cherry picked from commit cbfd392)
rffontenelle mentioned this pull request Nov 9, 2024
Closed
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Jan 30, 2025
Revert "pythonGH-121970: Extract availability into a new extension (
3f55056 
python#125082)"

This reverts commit cbfd392
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Jan 30, 2025
Revert "[3.12] pythonGH-121970: Extract availability into a new e…
9c0620a 
…xtension (pythonGH-125082) (python#125238)"

This reverts commit caa4924
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Jan 30, 2025
Revert "[3.13] pythonGH-121970: Extract availability into a new e…
962bc3f 
…xtension (pythonGH-125082) (python#125237)"

This reverts commit abb01fd.
m-aciek added a commit to m-aciek/cpython that referenced this pull request Jan 30, 2025
pythongh-126609: docs: revert changes made to the internal structure …
7d8ea9b 
…of availability directive

In python#125082.
m-aciek mentioned this pull request Jan 30, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
ezio-melotti Awaiting requested review from ezio-melotti

Assignees

AA-Turner

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL