gh-90102: Fix pyio return value - #125089
Merged
vstinner merged 1 commit intoOct 8, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Spotted by @ngnpope. `isatty` returns False to indicate the file is not a TTY. The C implementation of _io does that (`Py_RETURN_FALSE`) but I got the bool backwards in the _pyio implementaiton.
vstinner
enabled auto-merge (squash)
October 8, 2024 11:46
vstinner
disabled auto-merge
October 8, 2024 11:46
vstinner
enabled auto-merge (squash)
October 8, 2024 11:47
Copy link
Copy Markdown
Member
|
Oops, hopefully the bug was spotted quickly :-) |
Sorry, something went wrong.
efimov-mikhail
pushed a commit
to efimov-mikhail/cpython
that referenced
this pull request
Oct 9, 2024
Spotted by @ngnpope. `isatty` returns False to indicate the file is not a TTY. The C implementation of _io does that (`Py_RETURN_FALSE`) but I got the bool backwards in the _pyio implementaiton.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted by @ngnpope (https://github.com/python/cpython/pull/124922/files#r1791363776).
isatty returns False to indicate the file is not a TTY. The C implementation of _io does that (Py_RETURN_FALSE) but I got the bool backwards in the _pyio implementaiton.
cc: @vstinner