Repository navigation
gh-125196: Add fast-path for int in PyUnicodeWriter_WriteStr() - #125214
Merged
vstinner merged 1 commit intoOct 9, 2024
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
PyUnicodeWriter_WriteStr() and PyUnicodeWriter_WriteRepr() now call directly _PyLong_FormatWriter() if the object is an int.
Copy link
Copy Markdown
Member
Author
|
Benchmark using PR gh-125202 as reference: import pyperf
runner = pyperf.Runner()
runner.bench_func('repr([1,2,3])', repr, [1, 2, 3])
list2 = [123]*10
runner.bench_func('repr(list2)', repr, list2)
list3 = [123]*50
runner.bench_func('repr(list3)', repr, list3)
Comparison without / with this change: +----------------+---------+-----------------------+ | Benchmark | ref | change | +================+=========+=======================+ | repr([1,2,3]) | 291 ns | 189 ns: 1.54x faster | +----------------+---------+-----------------------+ | repr(list2) | 822 ns | 498 ns: 1.65x faster | +----------------+---------+-----------------------+ | repr(list3) | 3.01 us | 1.56 us: 1.93x faster | +----------------+---------+-----------------------+ | Geometric mean | (ref) | 1.70x faster | +----------------+---------+-----------------------+ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyUnicodeWriter_WriteStr() and PyUnicodeWriter_WriteRepr() now call directly _PyLong_FormatWriter() if the object is an int.