Pin the doctest workflow to Ubuntu 22.04 - #125236
Merged
AA-Turner merged 1 commit intoOct 10, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
hugovk
approved these changes
Oct 10, 2024
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2024
(cherry picked from commit 7a10cde) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2024
(cherry picked from commit 7a10cde) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-125240 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-125241 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
AA-Turner
added a commit
that referenced
this pull request
Oct 10, 2024
AA-Turner
added a commit
that referenced
this pull request
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes the simplest approach of pinning the runner-image to Ubuntu 22.04. Ubuntu-latest is being switched to 24.04, so we'll see intermitant failures.
We should aim to upgrade everything to 24.04, but that will take co-ordination with the autoconf work I believe (also see #122566).
A