Repository navigation
[3.12] [3.13] gh-124969: Fix locale.nl_langinfo(locale.ALT_DIGITS) (GH-124974) (GH-125232) - #125284
Merged
serhiy-storchaka merged 1 commit intoOct 11, 2024
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…thonGH-124974) (pythonGH-125232) (cherry picked from commit 26a9318) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Returns a tuple of up to 100 strings for ALT_DIGITS lookup (an empty tuple on most locales). Previously it returned the first item of that tuple or an empty string. (cherry picked from commit 21c04e1)
encukou
reviewed
Oct 11, 2024
Comment thread
Lib/test/test__locale.py
| with self.subTest(locale=loc): | ||
| alt_digits = nl_langinfo(locale.ALT_DIGITS) | ||
| self.assertIsInstance(alt_digits, tuple) | ||
| if count and not alt_digits and support.is_apple: |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
There's no support.is_apple on 3.12.
@ambv, should the macOS check be required to merge PRs?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Already is. #125311.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 26a9318)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
Returns a tuple of up to 100 strings for ALT_DIGITS lookup (an empty tuple on most locales).
Previously it returned the first item of that tuple or an empty string.
(cherry picked from commit 21c04e1)
📚 Documentation preview 📚: https://cpython-previews--125284.org.readthedocs.build/