Repository navigation
gh-125420: implement Sequence.index API on memoryview objects - #125446
Merged
JelleZijlstra merged 11 commits intoDec 10, 2024
Merged
JelleZijlstra merged 11 commits into
JelleZijlstra merged 11 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
corona10
reviewed
Oct 14, 2024
Comment thread
Objects/memoryobject.c
Copy link
Copy Markdown
Member
Author
|
Since you've approved the .count() PR, I think you want to have a look at this one as well @JelleZijlstra. |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Dec 10, 2024
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went for the simplest implementation. I could unroll the memory_item call to save some operations but I felt that it would only add noise and make maintenance harder so I went for a cleaner but probably a bit slower option.
📚 Documentation preview 📚: https://cpython-previews--125446.org.readthedocs.build/