FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) by graingert · Pull Request #125466 · python/cpython · GitHub

/ cpython Public

[3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) - #125466

Merged
1st1 merged 3 commits into
python:3.12from
graingert:backport-d5dbbf4-3.12
Oct 17, 2024
ConversationCommits (3)ChecksFiles changed
Merged

[3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959)#125466
1st1 merged 3 commits into
python:3.12from
graingert:backport-d5dbbf4-3.12

Conversation

graingert commented Oct 14, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Oct 14, 2024
Closed
graingert changed the title gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) [3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) Oct 14, 2024
bedevere-app Bot mentioned this pull request Oct 14, 2024
Merged
graingert closed this Oct 14, 2024
graingert reopened this Oct 14, 2024
graingert marked this pull request as ready for review October 14, 2024 15:45

1st1 commented Oct 15, 2024

Copy link
Copy Markdown
Member

What's this DO NOT MERGE label business?

graingert commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

What's this DO NOT MERGE label business?

@1st1 this was related to a failure on 3.14 (main) caused by a conflict with a different PR #124392

The do not merge label was added out of an abundance of caution assuming this PR was flaky when it is not. I removed the label

1st1 merged commit 32d4579 into python:3.12 Oct 17, 2024
graingert deleted the backport-d5dbbf4-3.12 branch October 17, 2024 07:44

gvanrossum commented Oct 18, 2024

Copy link
Copy Markdown
Member

What's this DO NOT MERGE label business?

@1st1 this was related to a failure on 3.14 (main) caused by a conflict with a different PR #124392

The do not merge label was added out of an abundance of caution assuming this PR was flaky when it is not. I removed the label

Sure, but please understand not everyone is aware of the reasons, so next time please add a comment to explain. (Also my pet peeve for revert PRs, too few people don’t say why it is being reverted and the OP has to hunt for the reason.)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL