| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Since this adds significant complexity and reversed() already works, I think we should only add this if it's actually faster than the current reversed(). If not, we can keep the current state at runtime and lie in the stub that __reversed__ exists; I feel that's relatively OK since it's a private dunder and people shouldn't be calling it directly anyway. |
Sorry, something went wrong.
I won't have the bandwidth to report the timings but I'll do it tomorrow. I won't be reachable until next Tuesday, so feel free to ignore this PR for now (we can always consider it later). |
Sorry, something went wrong.
|
There's some time left until the 3.14 feature freeze :) |
Sorry, something went wrong.
|
Some update: materializing the reversed iterator is now slower since precomputing the format is needed and other stuff is happening behind the scenes but consuming the iterator is faster once the number of items exceeds 32 (release non PGO). For smaller views, it's more or less the same speed (the call reversed(mv) is likely always slower with this specific implementation since we don't use a generic reversed object, but iterating will require a bit more work due to the internal format adjustment). I haven't implemented a vectorcall function so it's maybe why it's slower to materialize. (I'm just passing by) |
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry for the long review--a lot of these are formatting changes, but there are a few things that certainly need to get fixed.
Sorry, something went wrong.
There was a problem hiding this comment.
I did a bit of stress testing locally, and despite my best efforts, I was unable to get this to break 😉. LGTM, thank you!
Sorry, something went wrong.
|
Since we discussed about adding this one if needs arise, I will just close them and delete my branch for now (I have too many local branches and I don't want to keep stale PRs). We'll be able to reuse it later if needed. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.