FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-125542: Deprecate `prefix_chars` in `ArgumentParser.add_argument_group` by savannahostrowski · Pull Request #125563 · python/cpython · GitHub

/ cpython Public

gh-125542: Deprecate prefix_chars in ArgumentParser.add_argument_group - #125563

Merged
serhiy-storchaka merged 13 commits into
python:mainfrom
savannahostrowski:gh-125542
Oct 17, 2024
Merged

gh-125542: Deprecate prefix_chars in ArgumentParser.add_argument_group#125563
serhiy-storchaka merged 13 commits into
python:mainfrom
savannahostrowski:gh-125542

Conversation

savannahostrowski commented Oct 16, 2024
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

savannahostrowski changed the title Deprecate prefix_chars in ArgumentParser.add_argument_group gh-125542: Deprecate prefix_chars in ArgumentParser.add_argument_group Oct 16, 2024

savannahostrowski commented Oct 16, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

@serhiy-storchaka I wasn't sure if this should be considered more of a soft deprecation (targeting slated removal in 3.16 or similar) since I'm not really changing logic here to ignore this parameter/throw an error. Interested to hear your thoughts!

Comment thread Doc/library/argparse.rst
Comment thread Doc/library/argparse.rst Outdated
Comment thread Doc/library/argparse.rst
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Lib/argparse.py Outdated
Comment thread Lib/test/test_argparse.py Outdated
Comment thread Lib/test/test_argparse.py
Comment thread Lib/test/test_argparse.py Outdated

savannahostrowski commented Oct 17, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

It looks like using :ref: for parameters doesn't work cross-file (e.g., in news entries). After looking at other examples, it seems the right thing to do here is to use `` instead.

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

serhiy-storchaka enabled auto-merge (squash) October 17, 2024 08:48
serhiy-storchaka merged commit 7b04496 into python:main Oct 17, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
donbarbos added a commit to donbarbos/typeshed that referenced this pull request Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL