FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-123299: Provide replacement for removed sqlite3 attributes in What's New 3.14 by fry69 · Pull Request #125566 · python/cpython · GitHub

/ cpython Public

gh-123299: Provide replacement for removed sqlite3 attributes in What's New 3.14 - #125566

Merged
hugovk merged 4 commits into
python:mainfrom
fry69:patch-1
Jun 29, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-123299: Provide replacement for removed sqlite3 attributes in What's New 3.14#125566
hugovk merged 4 commits into
python:mainfrom
fry69:patch-1

Conversation

fry69 commented Oct 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Trivial doc fix to mention the actual SQLite3 version information attributes (I had to look that up, probably others will too)

📚 Documentation preview 📚: https://cpython-previews--125566.org.readthedocs.build/

ghost commented Oct 16, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 16, 2024

rruuaanng commented Oct 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please add [Doc] label for PR title. like this

Doc: xxx

fry69 changed the title mention actual sqlite3 version attributes in 3.14.rst [Doc] mention actual sqlite3 version attributes in 3.14.rst Oct 16, 2024
fry69 changed the title [Doc] mention actual sqlite3 version attributes in 3.14.rst Doc: mention actual sqlite3 version attributes in 3.14.rst Oct 16, 2024

fry69 commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

What is preferred:

[Doc] xxx

or

Doc: xxx

as a prefix for the title without issue #?

I used the latter for now. Should it be lowercase too like gh-*? I couldn't find guidance for trivial doc changes after a quick search through the contribution guides. Or should such trivial changes be avoided (e.g. to reduce the noise, sorry for that then)?

rruuaanng commented Oct 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

In fact, this's just a general behavior, use Doc to mark this PR as documentation.

Sorry, I seem to have missed an s, like this Docs.

fry69 changed the title Doc: mention actual sqlite3 version attributes in 3.14.rst Docs: mention actual sqlite3 version attributes in 3.14.rst Oct 16, 2024
StanFromIreland requested a review from hugovk June 28, 2025 10:51
StanFromIreland reviewed Jun 28, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Outdated

* Remove :data:`!version` and :data:`!version_info` from :mod:`sqlite3`.
* Remove :data:`!version` and :data:`!version_info` from :mod:`sqlite3`;
use :data:`!sqlite_version` and :data:`!sqlite_version_info` for actual SQLite3

StanFromIreland Jun 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These can be linked since they are not removed.

StanFromIreland changed the title Docs: mention actual sqlite3 version attributes in 3.14.rst gh-123299: Provide replacement for removed sqlite3 attributes in What's New 3.14 Jun 28, 2025
bedevere-app Bot mentioned this pull request Jun 28, 2025
Closed
hugovk reviewed Jun 28, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Outdated
hugovk added the needs backport to 3.14 bugs and security fixes label Jun 28, 2025
hugovk enabled auto-merge (squash) June 29, 2025 15:27
hugovk merged commit 7a403a8 into python:main Jun 29, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 29, 2025

miss-islington-app Bot commented Jun 29, 2025

Copy link
Copy Markdown

Thanks @fry69 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2025
pythongh-123299: Provide replacement for removed sqlite3 attributes i…
df8bcc3 
…n What's New 3.14 (pythonGH-125566)

(cherry picked from commit 7a403a8)

Co-authored-by: fry69 <142489379+fry69@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app Bot commented Jun 29, 2025

Copy link
Copy Markdown

GH-136103 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 29, 2025

hugovk commented Jun 29, 2025

Copy link
Copy Markdown
Member

@fry69 Thanks for the PR!

hugovk added a commit that referenced this pull request Jun 29, 2025
[3.14] gh-123299: Provide replacement for removed sqlite3 attributes …
eb8ed2a 
…in What's New 3.14 (GH-125566) (#136103)

Co-authored-by: fry69 <142489379+fry69@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-123299: Provide replacement for removed sqlite3 attributes i…
f521cf1 
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-123299: Provide replacement for removed sqlite3 attributes i…
d52a7d6 
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-123299: Provide replacement for removed sqlite3 attributes i…
28679f8 
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-123299: Provide replacement for removed sqlite3 attributes i…
6f68667 
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-123299: Provide replacement for removed sqlite3 attributes i…
acf7f1f 
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
StanFromIreland StanFromIreland left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL