FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-125746: Delay deprecated `zipimport.zipimporter.load_module` removal time to 3.15 by Wulian233 · Pull Request #125748 · python/cpython · GitHub

/ cpython Public

gh-125746: Delay deprecated zipimport.zipimporter.load_module removal time to 3.15 - #125748

Merged
brettcannon merged 8 commits into
python:mainfrom
Wulian233:zipimport
Feb 11, 2025
ConversationCommits (8)ChecksFiles changed
Merged

gh-125746: Delay deprecated zipimport.zipimporter.load_module removal time to 3.15#125748
brettcannon merged 8 commits into
python:mainfrom
Wulian233:zipimport

Conversation

Wulian233 commented Oct 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

#125746 (comment)

I would like to hold off on this change for one more version. A quick GitHub search shows that 1.8k projects are still relying on load_module (and my regular expression isn't perfect, so I'm certain that we're missing some).

The new zipimport methods (I'm using "new" loosely here, I'm talking about the 3.10 methods) were only added to typeshed in late June, so I would assume that many were intentionally using load_module over exec_module, because their IDE was telling them that it doesn't exist (to confirm that, adjusting my GitHub search shows that only 250 projects are using exec_module). Similarly, load_module isn't marked as @deprecated on typeshed, so when we did add it, it's unlikely that people realized they needed to migrate.

📚 Documentation preview 📚: https://cpython-previews--125748.org.readthedocs.build/

bedevere-app Bot mentioned this pull request Oct 20, 2024
Closed

rruuaanng commented Oct 20, 2024

Copy link
Copy Markdown
Contributor

I also encountered this problem, but I don't know why it happened. I opened an issue.

ZeroIntensity requested changes Oct 20, 2024
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would like to postpone this until 3.15. Please update the PR to move the load_module deprecation to pending-removal-in-3.15

Wulian233 changed the title gh-125746: Remove deprecated zipimport.zipimporter.load_module gh-125746: Delay deprecated zipimport.zipimporter.load_module removal time to 3.15 Oct 20, 2024

Wulian233 commented Oct 20, 2024

Copy link
Copy Markdown
Contributor Author

You're right, when I did this pr, my vscode (the latest Python extension) didn't prompt exec_module either. I will edit the pending-removal-in-3.15.rst and Lib/zipimport.py to remove the entries for pending-removal-in-future.rst

Wulian233 closed this Oct 21, 2024
Wulian233 reopened this Oct 21, 2024
ZeroIntensity approved these changes Oct 21, 2024
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! LGTM.

brettcannon requested changes Oct 21, 2024
View reviewed changes
Comment thread Lib/zipimport.py Outdated

bedevere-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

bedevere-app Bot requested a review from brettcannon October 21, 2024 22:54
brettcannon approved these changes Oct 22, 2024
View reviewed changes
Comment thread Doc/deprecations/pending-removal-in-3.15.rst Outdated
Update Doc/deprecations/pending-removal-in-3.15.rst
cfd1976 
Co-authored-by: Brett Cannon <brett@python.org>
Wulian233 mentioned this pull request Nov 10, 2024
Merged
picnixz reviewed Nov 10, 2024
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you check if there is a deprecated-removed directive to update in the corresponding docs entry?

Comment thread Doc/deprecations/pending-removal-in-3.15.rst Outdated
Comment thread Lib/zipimport.py Outdated
Comment thread Lib/zipimport.py Outdated
Comment thread Misc/NEWS.d/next/Library/2024-10-20-13-01-05.gh-issue-125746.wDLTay.rst Outdated

Wulian233 commented Nov 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@brettcannon Friendly ping:) maybe we can merge this? It should be fine now, thank you!

rruuaanng commented Nov 17, 2024

Copy link
Copy Markdown
Contributor

@Wulian233 Be patient, everyone has their own job :)

ZeroIntensity commented Nov 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Eh, IMO it's fine to remind someone to merge if the PR hasn't had any additional reviewers.

Wulian233 commented Feb 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

A few months later: A similar PR for the delayed removal of load_module in importlib #129855 was just merged and backported. Is this PR still needed?

cc @brettcannon

tomasr8 commented Feb 11, 2025

Copy link
Copy Markdown
Member

Is this PR still needed?

It is, this one updates zipimport, while the other one was for importlib.

brettcannon enabled auto-merge (squash) February 11, 2025 23:46
brettcannon merged commit 06ac157 into python:main Feb 11, 2025

brettcannon commented Feb 12, 2025

Copy link
Copy Markdown
Member

Sorry for the delay! Got swamped and this fell off my radar thinking I was waiting on something for the PR.

Wulian233 deleted the zipimport branch February 12, 2025 01:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
brettcannon brettcannon approved these changes
ZeroIntensity ZeroIntensity approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL