gh-125767: Fix pickling and copying of super objects - #125781
Merged
serhiy-storchaka merged 2 commits intoOct 21, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Previously, copying a super object returned a copy of the instance invoking super(). Pickling a super object could pickle the instance invoking super() or fail, depending on its type and protocol. Now deep copying returns a new super object and pickling pickles the super object. Shallow copying returns the same super object.
Comment thread
Doc/library/functions.rst
Outdated
Comment thread
Doc/whatsnew/3.14.rst
Outdated
Comment thread
Misc/NEWS.d/next/Library/2024-10-21-13-52-37.gh-issue-125767.0kK4lX.rst
Outdated
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Comment thread
Lib/copyreg.py
|
|
||
| pickle(type(int | str), pickle_union) | ||
|
|
||
| def pickle_super(obj): |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Should we give this a private name? All the existing ones also use public names, so I don't mind keeping this one public too.
Sorry, something went wrong.
JelleZijlstra
approved these changes
Oct 21, 2024
Eclips4
approved these changes
Oct 21, 2024
Copy link
Copy Markdown
Member
Author
|
Thank you for your suggestions and review @JelleZijlstra. |
Sorry, something went wrong.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…125781) Previously, copying a super object returned a copy of the instance invoking super(). Pickling a super object could pickle the instance invoking super() or fail, depending on its type and protocol. Now deep copying returns a new super object and pickling pickles the super object. Shallow copying returns the same super object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, copying a super object returned a copy of the instance invoking super(). Pickling a super object could pickle the instance invoking super() or fail, depending on its type and protocol.
Now deep copying returns a new super object and pickling pickles the super object. Shallow copying returns the same super object.
📚 Documentation preview 📚: https://cpython-previews--125781.org.readthedocs.build/