FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-125716: Use A Global Mutex When Initializing Global State For The _interpqueues Module by ericsnowcurrently · Pull Request #125803 · python/cpython · GitHub

/ cpython Public

gh-125716: Use A Global Mutex When Initializing Global State For The _interpqueues Module - #125803

Merged
ericsnowcurrently merged 10 commits into
python:mainfrom
ericsnowcurrently:fix-queues-null-mutex
Oct 21, 2024
ConversationCommits (10)ChecksFiles changed
Merged

gh-125716: Use A Global Mutex When Initializing Global State For The _interpqueues Module#125803
ericsnowcurrently merged 10 commits into
python:mainfrom
ericsnowcurrently:fix-queues-null-mutex

Conversation

ericsnowcurrently commented Oct 21, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This includes a drive-by cleanup in _queues_init() and _queues_fini().

This change also applies to the _interpchannels module.

bedevere-app Bot mentioned this pull request Oct 21, 2024
Closed

ericsnowcurrently commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

!buildbot AMD64 Arch Linux Usan Function

bedevere-bot commented Oct 21, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 27fcb3c 🤖

The command will test the builders whose names match following regular expression: AMD64 Arch Linux Usan Function

The builders matched are:

  • AMD64 Arch Linux Usan Function PR

ericsnowcurrently commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

The USAN buildbot passed test_interpreter_pool. It could be an intermittent race, but it's been failing fairly consistently on 3.x for several days, so the odds are in my favor. 😄 I'm going to proceed as though this fixes the problem but will monitor to see if there are further failures after this lands.

ericsnowcurrently commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

@ZeroIntensity, would you mind a quick review? Thanks!

ZeroIntensity approved these changes Oct 21, 2024
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this works. It's probably worth refactoring channels to use PyMutex over PyThread_type_lock in the future, but this is fine for now.

ericsnowcurrently merged commit 4848b0b into python:main Oct 21, 2024

miss-islington-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

ericsnowcurrently deleted the fix-queues-null-mutex branch October 21, 2024 21:50
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2024
pythongh-125716: Use A Global Mutex When Initializing Global State Fo…
b739d2e 
…r The _interpqueues Module (pythongh-125803)

This includes a drive-by cleanup in _queues_init() and _queues_fini().

This change also applies to the _interpchannels module.
(cherry picked from commit 4848b0b)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>

bedevere-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

GH-125817 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 21, 2024
ericsnowcurrently mentioned this pull request Oct 21, 2024
Merged
ericsnowcurrently added a commit that referenced this pull request Oct 21, 2024
[3.13] gh-125716: Use a Global Mutex When Initializing Global State F…
0e350d4 
…or the _interpqueues Module (gh-125817)

This includes a drive-by cleanup in _queues_init() and _queues_fini().

This change also applies to the _interpchannels module.

(cherry picked from commit 4848b0b, AKA gh-125803)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-125716: Use A Global Mutex When Initializing Global State Fo…
d996135 
…r The _interpqueues Module (pythongh-125803)

This includes a drive-by cleanup in _queues_init() and _queues_fini().

This change also applies to the _interpchannels module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL