Repository navigation
gh-123930: Correct test of attribute failure to account for iOS - #125959
Merged
freakboy3742 merged 2 commits intoOct 25, 2024
Merged
freakboy3742 merged 2 commits into
freakboy3742 merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
freakboy3742
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
October 25, 2024 06:28
Copy link
Copy Markdown
Contributor
Author
|
!buildbot iOS |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 41ed908 🤖 The command will test the builders whose names match following regular expression: iOS The builders matched are:
|
Sorry, something went wrong.
hauntsaninja
approved these changes
Oct 25, 2024
hauntsaninja
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you for the quick fix!
Sorry, something went wrong.
freakboy3742
enabled auto-merge (squash)
October 25, 2024 06:41
Copy link
Copy Markdown
Contributor
Author
|
!buildbot iOS |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 8111d82 🤖 The command will test the builders whose names match following regular expression: iOS The builders matched are:
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 25, 2024
…pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Copy link
Copy Markdown
|
GH-125960 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…python#125959) Update a test of importing attributes from binary modules to account for iOS conditions.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Feb 3, 2026
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Feb 3, 2026
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Jun 12, 2026
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Jun 12, 2026
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Oct 2, 2026
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Oct 2, 2026
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Oct 12, 2026
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#123929 improved the error message when a Python module shadows a binary module.
However, the test that was added didn't account for the behavior of the iOS import scheme. On iOS, the spec origin and the module's __file__ aren't equivalent, due to the iOS Framework loader. As a result, the test which was looking for the module's __file__ in the exception that is raised failed on the iOS buildbots.
On every other platform, The spec.origin and the module's __file__ are the same, so this PR updates the test to use the spec's origin.