GH-125866: Improve tests for pathname2url() and url2pathname() - #125993
Merged
barneygale merged 5 commits intoOct 29, 2024
Merged
GH-125866: Improve tests for pathname2url() and url2pathname()#125993barneygale merged 5 commits into
barneygale merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Merge `URL2PathNameTests` `PathName2URLTests` and test cases (which test only the Windows-specific implementations from `nturl2path`) into the main `Pathname_Tests` test case for these functions. Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.
rruuaanng
approved these changes
Oct 26, 2024
rruuaanng
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
zooba
approved these changes
Oct 29, 2024
zooba
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks fine. I think you may need to merge from main to get the last remaining checks to complete.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you both for the reviews, much appreciated! |
Sorry, something went wrong.
barneygale
enabled auto-merge (squash)
October 29, 2024 20:23
Copy link
Copy Markdown
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 29, 2024
…()` (pythonGH-125993) Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test only the Windows-specific implementations from `nturl2path`) into the main `Pathname_Tests` test case for these functions. Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`. (cherry picked from commit 6742f14) Co-authored-by: Barney Gale <barney.gale@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 29, 2024
…()` (pythonGH-125993) Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test only the Windows-specific implementations from `nturl2path`) into the main `Pathname_Tests` test case for these functions. Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`. (cherry picked from commit 6742f14) Co-authored-by: Barney Gale <barney.gale@gmail.com>
Copy link
Copy Markdown
|
GH-126144 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-126145 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
barneygale
added a commit
that referenced
this pull request
Oct 29, 2024
…e()` (GH-125993) (#126145) GH-125866: Improve tests for `pathname2url()` and `url2pathname()` (GH-125993) Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test only the Windows-specific implementations from `nturl2path`) into the main `Pathname_Tests` test case for these functions. Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`. (cherry picked from commit 6742f14) Co-authored-by: Barney Gale <barney.gale@gmail.com>
barneygale
added a commit
that referenced
this pull request
Oct 29, 2024
…e()` (GH-125993) (#126144) GH-125866: Improve tests for `pathname2url()` and `url2pathname()` (GH-125993) Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test only the Windows-specific implementations from `nturl2path`) into the main `Pathname_Tests` test case for these functions. Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`. (cherry picked from commit 6742f14) Co-authored-by: Barney Gale <barney.gale@gmail.com>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…()` (python#125993) Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test only the Windows-specific implementations from `nturl2path`) into the main `Pathname_Tests` test case for these functions. Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…()` (python#125993) Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test only the Windows-specific implementations from `nturl2path`) into the main `Pathname_Tests` test case for these functions. Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge URL2PathNameTests and PathName2URLTests test cases (which test only the Windows-specific implementations from nturl2path) into the main Pathname_Tests test case for these functions.
Copy/port some test cases that were originally written for pathlib.Path.as_uri() and from_uri().