FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-125916: Adapt functools.reduce() to Argument Clinic by skirpichev · Pull Request #125999 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-125916: Adapt functools.reduce() to Argument Clinic - #125999

Merged
erlend-aasland merged 18 commits into
python:mainfrom
skirpichev:reduce-to-ac
Nov 1, 2024
ConversationCommits (18)ChecksFiles changed
Merged

gh-125916: Adapt functools.reduce() to Argument Clinic#125999
erlend-aasland merged 18 commits into
python:mainfrom
skirpichev:reduce-to-ac

Conversation

skirpichev commented Oct 26, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Oct 26, 2024
Closed

skirpichev commented Oct 26, 2024

Copy link
Copy Markdown
Member Author

This coming from #125917. Red alert: to make AC happy, docstring was adjusted.

I did some benchmarks.

Details 
# a.py
import pyperf
from functools import reduce

f = lambda x, y: x + y
lst = list(range(5))
init = 123

runner = pyperf.Runner()
runner.bench_func('reduce(f, lst)', reduce, f, lst)
runner.bench_func('reduce(f, lst, init)', reduce, f, lst, init)

Run e.g. with: python a.py -q -o ref.json.

with results:

Benchmark ref patch
reduce(f, lst) 1.27 us 1.19 us: 1.07x faster
reduce(f, lst, init) 1.43 us 1.36 us: 1.05x faster
Geometric mean (ref) 1.06x faster

So, at least AC-backed argument processing offer some speedup.

skirpichev mentioned this pull request Oct 26, 2024
Merged

erlend-aasland commented Oct 26, 2024

Copy link
Copy Markdown
Contributor

Thanks Sergey, I'll review this within today. Ping me tomorrow if I forget.

JelleZijlstra reviewed Oct 26, 2024
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
serhiy-storchaka reviewed Oct 26, 2024
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
erlend-aasland reviewed Oct 26, 2024
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
JelleZijlstra reviewed Oct 27, 2024
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
Improve functools.reduce() docstring
a22cef9 
PEP 257 says that "Multi-line docstrings consist of a summary line just
like a one-line docstring, followed by a blank line, followed by a more
elaborate description."  This is also a requirement from the Argument
Clinic.
skirpichev mentioned this pull request Oct 27, 2024
Merged
rhettinger removed their request for review October 28, 2024 01:45
skirpichev and others added 2 commits October 28, 2024 07:26
Apply suggestions from code review
ea5ae96 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Merge branch 'main' into reduce-docstring
c0e7786
skirpichev commented Oct 28, 2024
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
erlend-aasland pushed a commit that referenced this pull request Oct 29, 2024
Align functools.reduce() docstring with PEP-257 (#126045)
9b14083 
Yak-shave in preparation for Argument Clinic adaption in gh-125999.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2024
Align functools.reduce() docstring with PEP-257 (pythonGH-126045)
78e59af 
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
(cherry picked from commit 9b14083)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
miss-islington mentioned this pull request Oct 29, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2024
Align functools.reduce() docstring with PEP-257 (pythonGH-126045)
112730d 
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
(cherry picked from commit 9b14083)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
miss-islington mentioned this pull request Oct 29, 2024
Merged
erlend-aasland pushed a commit that referenced this pull request Oct 29, 2024
[3.13] Align functools.reduce() docstring with PEP-257 (GH-126045) (#…
e7c6310 
…126113)

Yak-shave in preparation for Argument Clinic adaption in gh-125999.

(cherry picked from commit 9b14083)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
erlend-aasland pushed a commit that referenced this pull request Oct 29, 2024
[3.12] Align functools.reduce() docstring with PEP-257 (GH-126045) (#…
a8472fd 
…126114)

Yak-shave in preparation for Argument Clinic adaption in gh-125999.

(cherry picked from commit 9b14083)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
erlend-aasland changed the title gh-125916: convert reduce() to Argument Clinic gh-125916: Adapt functools.reduce() to Argument Clinic Oct 29, 2024
skirpichev and others added 2 commits October 29, 2024 13:55
Update Modules/_functoolsmodule.c
d86570b 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
+1
b011243

erlend-aasland commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

I'll give Jelle and Serhiy a chance to chime in again before landing this.

erlend-aasland commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

I plan to land this later today (post noon ET).

serhiy-storchaka reviewed Nov 1, 2024
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
skirpichev and others added 2 commits November 1, 2024 18:19
Update Modules/_functoolsmodule.c
ebed8da 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
+1
57f71d0
erlend-aasland merged commit 51ef54a into python:main Nov 1, 2024

erlend-aasland commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR, Sergey; thanks for the reviews, Jelle and Serhiy.

skirpichev deleted the reduce-to-ac branch November 2, 2024 03:10
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
Align functools.reduce() docstring with PEP-257 (python#126045)
5e75d4d 
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
pythongh-125916: Adapt functools.reduce() to Argument Clinic (python#…
a156925 
…125999)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Align functools.reduce() docstring with PEP-257 (python#126045)
c3664b4 
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-125916: Adapt functools.reduce() to Argument Clinic (python#…
14e5e9f 
…125999)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
JelleZijlstra JelleZijlstra approved these changes
erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL