FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-125028: Prohibit placeholders in partial keywords by dg-pb · Pull Request #126062 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-125028: Prohibit placeholders in partial keywords - #126062

Merged
serhiy-storchaka merged 16 commits into
python:mainfrom
dg-pb:gh-125028-prohibit-kw-placeholders
May 8, 2025
ConversationCommits (16)ChecksFiles changed
Merged

gh-125028: Prohibit placeholders in partial keywords#126062
serhiy-storchaka merged 16 commits into
python:mainfrom
dg-pb:gh-125028-prohibit-kw-placeholders

Conversation

dg-pb commented Oct 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

dg-pb requested a review from rhettinger as a code owner October 28, 2024 06:53
bedevere-app Bot mentioned this pull request Oct 28, 2024
Closed
dg-pb mentioned this pull request Oct 28, 2024
Closed
erlend-aasland reviewed Oct 28, 2024
View reviewed changes
Comment thread Lib/functools.py Outdated
Comment thread Modules/_functoolsmodule.c Outdated
dg-pb marked this pull request as draft October 30, 2024 08:59
dg-pb marked this pull request as ready for review October 30, 2024 10:16
zhangyx1998 reviewed Nov 14, 2024
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
erlend-aasland reviewed Jan 4, 2025
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
Comment thread Modules/_functoolsmodule.c Outdated
dg-pb and others added 2 commits January 5, 2025 10:03
Idiomatic C
5abc61e 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
remove unrelated changes
656361b 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland reviewed Jan 5, 2025
View reviewed changes
Comment thread Lib/test/test_functools.py Outdated
Comment thread Modules/_functoolsmodule.c Outdated
dg-pb and others added 2 commits January 5, 2025 14:56
loosen the regex in test
da4214a 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
improved error message
26dded8
erlend-aasland requested changes Jan 5, 2025
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please amend Doc/library/functools.rst and Doc/whatsnew/3.14.rst as needed.

bedevere-app Bot commented Jan 5, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

dg-pb commented Jan 5, 2025

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-app Bot commented Jan 5, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

bedevere-app Bot requested a review from erlend-aasland January 5, 2025 21:40

erlend-aasland commented Jan 5, 2025

Copy link
Copy Markdown
Contributor

Thanks, looks good to me. I'd like Serhiy's eyes on it also.

serhiy-storchaka reviewed Jan 6, 2025
View reviewed changes
Comment thread Lib/test/test_functools.py
Comment thread Lib/functools.py Outdated
Comment thread Modules/_functoolsmodule.c
Comment thread Modules/_functoolsmodule.c Outdated
dg-pb mentioned this pull request Jan 6, 2025
Open
serhiy-storchaka approved these changes Jan 6, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Comment thread Lib/test/test_functools.py Outdated
dg-pb mentioned this pull request Jan 6, 2025
Open
serhiy-storchaka reviewed Jan 7, 2025
View reviewed changes
Comment thread Lib/test/test_functools.py Outdated
serhiy-storchaka reviewed Jan 7, 2025
View reviewed changes
Comment thread Lib/test/test_functools.py Outdated

dg-pb commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

@rhettinger, @serhiy-storchaka
This is API adjustment for new feature, thus I think it would be good to merge this before 3.14 release. Given it is a fairly small one, maybe it would be good to get it out of the way sooner than later?

Also, what are your thoughts on:

  1. gh-119109: improve functools.partial vectorcall with keywords #124584 - in addition to intended improvements this one solves current free-threading issue (the last one in that series) - Race between partial_vectorcall_fallback and _PyVectorcall_FunctionInline under free-threading #128050
  2. gh-124652: partialmethod simplifications #124788 - this one would simplify some complexity in inspect and make partialmethod a bit more performant

Should either of the above be aimed to be merged before 3.14 or is it not of importance?

serhiy-storchaka approved these changes May 8, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

It should go in 3.14, no question. It is much easier to prohibit this in 3.14, that in any following version, when we would need to pass through a deprecation process. On other hand, we can allow Placeholder as a keyword argument at any time if it is needed.

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
serhiy-storchaka merged commit afed5f8 into python:main May 8, 2025

miss-islington-app Bot commented May 8, 2025

Copy link
Copy Markdown

Thanks @dg-pb for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2025
pythongh-125028: Prohibit placeholders in partial keywords (pythonGH-…
ca03090 
…126062)

(cherry picked from commit afed5f8)

Co-authored-by: dgpb <3577712+dg-pb@users.noreply.github.com>

bedevere-app Bot commented May 8, 2025

Copy link
Copy Markdown

GH-133645 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 8, 2025
serhiy-storchaka pushed a commit that referenced this pull request May 8, 2025
[3.14] gh-125028: Prohibit placeholders in partial keywords (GH-126062)…
effe8d4 
… (GH-133645)

(cherry picked from commit afed5f8)

Co-authored-by: dgpb <3577712+dg-pb@users.noreply.github.com>
dg-pb deleted the gh-125028-prohibit-kw-placeholders branch May 8, 2025 11:57
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-125028: Prohibit placeholders in partial keywords (pythonGH-…
08acc1f 
…126062)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-125028: Prohibit placeholders in partial keywords (pythonGH-…
fc6bac1 
…126062)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
erlend-aasland erlend-aasland approved these changes
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
+1 more reviewer
zhangyx1998 zhangyx1998 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL