GH-125866: RFC8089 file URIs in urllib.request - #126148
Closed
barneygale wants to merge 12 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Adjust `urllib.request.pathname2url` and `url2pathname()` to generate and accept file URIs as described in RFC8089. `pathname2url()` gains a new *include_scheme* argument, which defaults to false. When set to true, the returned URL includes a `file:` prefix. `url2pathname()` now automatically removes a `file:` prefix if present. On Windows, `pathname2url()` now generates URIs that begin with two slashes rather than four when given a UNC path. On other platforms, `pathname2url()` now generates URIs that begin with three slashes rather than one when given an absolute path. `url2pathname()` now performs the opposite transformation, so `file:///etc/hosts` becomes `/etc/hosts`. Furthermore, `url2pathname()` now ignores local hosts (like "localhost" or any alias) and raises `URLError` for non-local hosts.
Copy link
Copy Markdown
Contributor
Author
|
Test failures will go away when #125739 lands |
Sorry, something went wrong.
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Nov 23, 2024
… POSIX paths When handed an absolute Windows path such as `C:\foo` or `//server/share`, the `urllib.request.pathname2url()` function returns a URL with an authority section, such as `///C:/foo` or `//server/share` (or before pythonGH-126205, `////server/share`). Only the `file:` prefix is omitted. But when handed an absolute POSIX path such as `/etc/hosts`, or a Windows path of the same form (rooted but lacking a drive), the function returns a URL without an authority section, such as `/etc/hosts`. This patch corrects the discrepancy by adding a `//` prefix before drive-less, rooted paths when generating URLs.
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Nov 24, 2024
Copy link
Copy Markdown
Contributor
Author
|
FWIW, I decided to do this in a more piecemeal fashion. The latest PR at time of writing is here: #126844 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust urllib.request.pathname2url() and url2pathname() to generate and accept file URIs as described in RFC8089.
pathname2url() gains a new include_scheme argument, which defaults to false. When set to true, the returned URL includes a file: prefix. url2pathname() now automatically removes a file: prefix if present.
On Windows, pathname2url() now generates URIs that begin with two slashes rather than four when given a UNC path.
On other platforms, pathname2url() now generates URIs that begin with three slashes rather than one when given an absolute path. url2pathname() now performs the opposite transformation, so file:///etc/hosts becomes /etc/hosts. Furthermore, url2pathname() now ignores local hosts (like "localhost" or any alias) and raises URLError for non-local hosts.
pathname2url() examples (star marks differences):
url2pathname() examples (star marks differences):
📚 Documentation preview 📚: https://cpython-previews--126148.org.readthedocs.build/