| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I don't understand how the JIT failures could be related. |
Sorry, something went wrong.
|
@savannahostrowski @diegorusso My JIT experts, are these known failures, or is there something wrong with my fix? |
Sorry, something went wrong.
|
@ZeroIntensity The aarch64 failures are known/expected. This is what we were discussing over Discord a couple of days back. Right now, we are waiting for this to be fixed in the aarch64 macos runners. As for the emulated Linux failures, sometimes we do see failures here, and that's why we maintain this list of tests to skip. I will note that this test was seen recently passing in https://github.com/python/cpython/actions/runs/11647994504/job/32434030552?pr=126339). If this PR has nothing to do with test.test_subprocess.POSIXProcessTestCase.test_vfork_used_when_expected (and I suspect it doesn't...), it may need to be added to the skip list. |
Sorry, something went wrong.
|
Thank you, Savannah! I'll update the skip list and see if that fixes it. |
Sorry, something went wrong.
…pected to the skip list.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Would it be possible to backport the test to 3.12 and 3.13? |
Sorry, something went wrong.
|
Maybe, but would it be all that useful? Anything that gets backported to those versions will (probably) have to go through the test on main anyway. |
Sorry, something went wrong.
|
It's useful to check for non-regression: make sure that we don't break this code path in the future. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Apparently, gh-126366 has two issues: one is a thread safety problem inside list.__init__, and then the other is that the GET_YIELD_FROM_ITER instruction crashes if a non-native-generator object raises an exception in its __iter__. Since the latter only applies to 3.14, I'm splitting the fix into two PRs.