FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-126374: Add support of options with optional arguments in the getopt module by serhiy-storchaka · Pull Request #126375 · python/cpython · GitHub

/ cpython Public

gh-126374: Add support of options with optional arguments in the getopt module - #126375

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:getopt-optional
Nov 11, 2024
ConversationCommits (5)ChecksFiles changed
Merged

gh-126374: Add support of options with optional arguments in the getopt module#126375
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:getopt-optional

Conversation

serhiy-storchaka commented Nov 3, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Nov 3, 2024
Closed
brianschubert reviewed Nov 3, 2024
View reviewed changes
Comment thread Doc/library/getopt.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2024-11-03-23-25-07.gh-issue-126374.Xu_THP.rst Outdated
Apply suggestions from code review
3105620 
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>

serhiy-storchaka commented Nov 4, 2024

Copy link
Copy Markdown
Member Author

Thank you for your suggestions @brianschubert.

erlend-aasland reviewed Nov 4, 2024
View reviewed changes
Comment thread Doc/library/getopt.rst Outdated
Update Doc/library/getopt.rst
efc63db 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
serhiy-storchaka mentioned this pull request Nov 6, 2024
Merged
serhiy-storchaka commented Nov 7, 2024
View reviewed changes
Comment thread Lib/test/test_getopt.py
serhiy-storchaka merged commit 25aee21 into python:main Nov 11, 2024
serhiy-storchaka deleted the getopt-optional branch November 11, 2024 16:29

brianschubert commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

Sorry if I'm missing some context, but since this is a new feature, shouldn't it have gotten at least one green-check review before being merged?

Per Workflow change coming: mandatory reviews on new features

gpshead added the type-feature A feature request or enhancement label Nov 13, 2024

gpshead commented Nov 13, 2024

Copy link
Copy Markdown
Member

Sorry if I'm missing some context, but since this is a new feature, shouldn't it have gotten at least one green-check review before being merged?

Technically yes. Our automation cannot detect and label such things accurately. LGTM on this change. For what its worth I had seen these changes as part of #126393 (which was stacked on top of this) prior to this and was happy with them; Serhiy answered a question I had left there on what turned out to be this PRs changes. we just hadn't connected all the dots to make that obvious on github.

picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
pythongh-126374: Add support of options with optional arguments in th…
de49afc 
…e getopt module (pythonGH-126375)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-126374: Add support of options with optional arguments in th…
f41632c 
…e getopt module (pythonGH-126375)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland left review comments
brianschubert brianschubert left review comments

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL