gh-119793: Prefer map(..., strict=True) over starmap/zip in examples - #126407
Merged
vstinner merged 1 commit intoNov 5, 2024
Merged
gh-119793: Prefer map(..., strict=True) over starmap/zip in examples#126407vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
skirpichev
approved these changes
Nov 5, 2024
vstinner
approved these changes
Nov 5, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Example:
>>> p=[1,2,3] >>> q=[4,5,6] >>> import math >>> math.sumprod(p, q) 32 >>> import itertools, operator >>> sum(itertools.starmap(operator.mul, zip(p, q, strict=True))) 32 >>> sum(map(operator.mul, p, q)) 32
Sorry, something went wrong.
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a docs-only change that updates the examples to use map(..., strict=True) instead of starmap(..., zip(..., strict=True)) which should improve readability.
📚 Documentation preview 📚: https://cpython-previews--126407.org.readthedocs.build/