FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-126451: Register contextvars.Context to collections.abc.Mapping by tungol · Pull Request #126452 · python/cpython · GitHub

/ cpython Public

gh-126451: Register contextvars.Context to collections.abc.Mapping #126452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 10 commits into from
Nov 6, 2024
Conversation 20 Commits 10 Checks 0 Files changed
Merged

gh-126451: Register contextvars.Context to collections.abc.Mapping #126452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
74b3631
Register contextvars.Context to collections.abc.Mapping
tungol Nov 5, 2024
9c4e3f5
test that all the methods are present
tungol Nov 5, 2024
3a1f8b2
test for callability, sort methods alphabetically in the test
tungol Nov 5, 2024
8c68b5b
minor spacing
tungol Nov 5, 2024
aa0da03
Update Misc/NEWS.d/next/Library/2024-11-05-11-28-45.gh-issue-126451.X…
tungol Nov 5, 2024
72d6726
import _collections_abc instead of collections.abc
tungol Nov 5, 2024
b0c38e8
use subtests
tungol Nov 5, 2024
96e2280
add issubclass check
tungol Nov 6, 2024
5cdad6a
Update Lib/test/test_context.py
tungol Nov 6, 2024
0e0a5e6
fix duplicate line
tungol Nov 6, 2024
File filter

Filter by extension

Filter by extension .py  (2) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 4 additions & 0 deletions Lib/contextvars.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import _collections_abc
from _contextvars import Context, ContextVar, Token, copy_context


__all__ = ('Context', 'ContextVar', 'Token', 'copy_context')


_collections_abc.Mapping.register(Context)
14 changes: 14 additions & 0 deletions Lib/test/test_context.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import collections.abc
import concurrent.futures
import contextvars
import functools
Expand Down Expand Up @@ -350,6 +351,19 @@ def ctx2_fun():

ctx1.run(ctx1_fun)

def test_context_isinstance(self):
ctx = contextvars.Context()
self.assertIsInstance(ctx, collections.abc.Mapping)
Comment thread
tungol marked this conversation as resolved.
self.assertTrue(issubclass(contextvars.Context, collections.abc.Mapping))

mapping_methods = (
'__contains__', '__eq__', '__getitem__', '__iter__', '__len__',
'__ne__', 'get', 'items', 'keys', 'values',
)
for name in mapping_methods:
Comment thread
kumaraditya303 marked this conversation as resolved.
with self.subTest(name=name):
self.assertTrue(callable(getattr(ctx, name)))

@isolated_context
@threading_helper.requires_working_threading()
def test_context_threads_1(self):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2024-11-05-11-28-45.gh-issue-126451.XJMtqz.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Register the :class:`contextvars.Context` type to
:class:`collections.abc.Mapping`.
Back | FazBrowse Home | New Git URL