Repository navigation
rtd: Compare against the merge-base rather than main - #126628
Closed
zware wants to merge 4 commits into
Closed
zware wants to merge 4 commits into
zware wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'd forgotten about this, but after stumbling across it again I think it's still relevant. Basically the goal here is to avoid RTD builds where the change in Doc/ actually happened on main past the branch point rather than on the PR branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Closing in favor of GH-149429, which I think handles this better. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this branch is currently based on the merge-base of 3.13 and main to test a way out of date starting point to see what happens.