FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-126332: Fix pyrepl crash for double ctrl-z in line overflow by eendebakpt · Pull Request #126650 · python/cpython · GitHub

/ cpython Public

gh-126332: Fix pyrepl crash for double ctrl-z in line overflow - #126650

Merged
pablogsal merged 5 commits into
python:mainfrom
eendebakpt:pyrepl_ctrl_z
Jan 21, 2025
ConversationCommits (5)ChecksFiles changed
Merged

gh-126332: Fix pyrepl crash for double ctrl-z in line overflow#126650
pablogsal merged 5 commits into
python:mainfrom
eendebakpt:pyrepl_ctrl_z

Conversation

eendebakpt commented Nov 10, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Notes:

  • Fix crash of pyrepl in windows when a double ctrl-z is entered on an overflowing line.
  • The fix can also be put into the str_width method instead of the wlen method. Both of these are not documented, so I am not sure whether one location should be preferred over the other.

bedevere-app Bot mentioned this pull request Nov 10, 2024
Closed
vstinner reviewed Jan 19, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would it be possible to add a new Lib/test/test_pyrepl/test_utils.py file and add tests on wlen() and str_width() functions?

eendebakpt mentioned this pull request Jan 21, 2025
Closed

pablogsal commented Jan 21, 2025

Copy link
Copy Markdown
Member

Would it be possible to add a new Lib/test/test_pyrepl/test_utils.py file and add tests on wlen() and str_width() functions?

I think we should do this in a separate PR. @eendebakpt do you want to open a PR for that?

pablogsal added the needs backport to 3.13 bugs and security fixes label Jan 21, 2025
pablogsal merged commit d147e5e into python:main Jan 21, 2025

miss-islington-app Bot commented Jan 21, 2025

Copy link
Copy Markdown

Thanks @eendebakpt for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2025
pythongh-126332: Fix pyrepl crash for double ctrl-z in line overflow (p…
91eb997 
…ythonGH-126650)

(cherry picked from commit d147e5e)

Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

bedevere-app Bot commented Jan 21, 2025

Copy link
Copy Markdown

GH-129154 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 21, 2025
pablogsal pushed a commit that referenced this pull request Jan 21, 2025
[3.13] gh-126332: Fix pyrepl crash for double ctrl-z in line overflow (…
0c70453 
…GH-126650) (#129154)

gh-126332: Fix pyrepl crash for double ctrl-z in line overflow (GH-126650)

(cherry picked from commit d147e5e)

Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

eendebakpt commented Jan 26, 2025

Copy link
Copy Markdown
Contributor Author

@pablogsal I added some tests in #129325

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL