[3.13] gh-126688: Reinit import lock after fork (GH-126692) - #126765
Merged
colesbury merged 1 commit intoNov 12, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The PyMutex implementation supports unlocking after fork because we clear the list of waiters in parking_lot.c. This doesn't work as well for _PyRecursiveMutex because on some systems, such as SerenityOS, the thread id is not preserved across fork(). (cherry picked from commit 5610860) Co-authored-by: Sam Gross <colesbury@gmail.com>
miss-islington
requested review from
brettcannon,
ericsnowcurrently,
kumaraditya303,
ncoghlan and
warsaw
as code owners
November 12, 2024 21:26
colesbury
enabled auto-merge (squash)
November 12, 2024 21:38
oskar-skog
added a commit
to oskar-skog/serenity
that referenced
this pull request
Nov 12, 2024
oskar-skog
added a commit
to oskar-skog/serenity
that referenced
this pull request
Nov 12, 2024
python/cpython#126765 Closes SerenityOS#25263 Make sure to revert this commit before updating Python.
nico
pushed a commit
to SerenityOS/serenity
that referenced
this pull request
Nov 13, 2024
python/cpython#126765 Closes #25263 Make sure to revert this commit before updating Python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PyMutex implementation supports unlocking after fork because we
clear the list of waiters in parking_lot.c. This doesn't work as well
for _PyRecursiveMutex because on some systems, such as SerenityOS, the
thread id is not preserved across fork().
(cherry picked from commit 5610860)
Co-authored-by: Sam Gross colesbury@gmail.com