FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-126780: Fix `ntpath.normpath()` for drive-relative paths by nineteendo · Pull Request #126801 · python/cpython · GitHub

/ cpython Public

gh-126780: Fix ntpath.normpath() for drive-relative paths - #126801

Merged
zooba merged 4 commits into
python:mainfrom
nineteendo:fix-ntpath.normpath
Nov 21, 2024
ConversationCommits (4)ChecksFiles changed
Merged

gh-126780: Fix ntpath.normpath() for drive-relative paths#126801
zooba merged 4 commits into
python:mainfrom
nineteendo:fix-ntpath.normpath

Conversation

nineteendo commented Nov 13, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Nov 13, 2024
Closed
nineteendo marked this pull request as ready for review November 13, 2024 19:15

nineteendo commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

cc @zooba, @barneygale

barneygale approved these changes Nov 14, 2024
View reviewed changes

barneygale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The test cases LGTM but I haven't reviewed the C code. Thanks

zooba merged commit 60ec854 into python:main Nov 21, 2024
zooba added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 21, 2024

miss-islington-app Bot commented Nov 21, 2024

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Nov 21, 2024

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Nov 21, 2024

Copy link
Copy Markdown

Sorry, @nineteendo and @zooba, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 60ec854bc297e04718fe13db3605d0465bf8badb 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2024
pythongh-126780: Fix ntpath.normpath() for drive-relative paths (py…
f7671da 
…thonGH-126801)

(cherry picked from commit 60ec854)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>

zooba commented Nov 21, 2024

Copy link
Copy Markdown
Member

Not sure if we need to go back to 3.12, but letting the bot decide... guess not!

bedevere-app Bot commented Nov 21, 2024

Copy link
Copy Markdown

GH-127103 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 21, 2024
zooba removed the needs backport to 3.12 only security fixes label Nov 21, 2024
nineteendo deleted the fix-ntpath.normpath branch November 21, 2024 14:46

nineteendo commented Nov 21, 2024

Copy link
Copy Markdown
Contributor Author

Thanks.

zooba pushed a commit that referenced this pull request Nov 21, 2024
gh-126780: Fix ntpath.normpath() for drive-relative paths (GH-126801)
48eb5c9 
(cherry picked from commit 60ec854)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-126780: Fix ntpath.normpath() for drive-relative paths (py…
61ef41b 
…thonGH-126801)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

barneygale barneygale approved these changes
zooba Awaiting requested review from zooba
eryksun Awaiting requested review from eryksun
+1 more reviewer
ruidazeng ruidazeng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL