FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-126980: Fix `bytearray.__buffer__` crash on `PyBUF_{READ,WRITE}` by sobolevn · Pull Request #126981 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-126980: Fix bytearray.__buffer__ crash on PyBUF_{READ,WRITE} - #126981

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-126980
Nov 19, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-126980: Fix bytearray.__buffer__ crash on PyBUF_{READ,WRITE}#126981
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-126980

Conversation

sobolevn commented Nov 18, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Related #114802

@JelleZijlstra, since you are __buffer__ PEP author, could you please take a look? :)

bedevere-app Bot mentioned this pull request Nov 18, 2024
Closed
vstinner reviewed Nov 19, 2024
View reviewed changes
Comment thread Lib/test/test_buffer.py Outdated

JelleZijlstra commented Nov 19, 2024

Copy link
Copy Markdown
Member

@JelleZijlstra, since you are __buffer__ PEP author, could you please take a look? :)

I don't think I wrote bytearray_getbuffer; the buffer protocol predates my PEP. This change looks good to me though, thanks!

Update Lib/test/test_buffer.py
99c2ed3 
Co-authored-by: Victor Stinner <vstinner@python.org>
sobolevn added the needs backport to 3.13 only security fixes label Nov 19, 2024

sobolevn commented Nov 19, 2024

Copy link
Copy Markdown
Member Author

This needs backport to 3.13: https://github.com/python/cpython/blob/3.13/Objects/abstract.c#L770-L774
But not to 3.12: https://github.com/python/cpython/blob/3.12/Objects/abstract.c#L718

sobolevn merged commit 3932e1d into python:main Nov 19, 2024

miss-islington-app Bot commented Nov 19, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Nov 19, 2024

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3932e1db5353bbcf3e3c1133cc9d2cde654cb645 3.13

sobolevn commented Nov 19, 2024

Copy link
Copy Markdown
Member Author

Will do a manual one.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Nov 19, 2024
[3.13] pythongh-126980: Fix bytearray.__buffer__ crash on `PyBUF_{R…
c2c44c0 
…EAD,WRITE}` (pythonGH-126981)

(cherry picked from commit 3932e1d)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Victor Stinner <vstinner@python.org>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Nov 19, 2024
[3.13] pythongh-126980: Fix bytearray.__buffer__ crash on `PyBUF_{R…
c13b5b2 
…EAD,WRITE}` (pythonGH-126981)

(cherry picked from commit 3932e1d)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-app Bot commented Nov 19, 2024

Copy link
Copy Markdown

GH-127023 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 19, 2024
sobolevn added a commit that referenced this pull request Nov 19, 2024
[3.13] gh-126980: Fix bytearray.__buffer__ crash on `PyBUF_{READ,WR…
3fae84f 
…ITE}` (GH-126981) (#127023)

(cherry picked from commit 3932e1d)

Co-authored-by: Victor Stinner <vstinner@python.org>
sobolevn mentioned this pull request Nov 19, 2024
Merged
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-126980: Fix bytearray.__buffer__ crash on `PyBUF_{READ,WRI…
206d013 
…TE}` (python#126981)

Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
skirpichev skirpichev approved these changes
JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

sobolevn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL