Repository navigation
Allow local use of static PyMutex in the C analyzer - #127102
vstinner merged 4 commits into
Conversation
Sorry, something went wrong.
|
Can you rebase your PR on the main branch and remove: diff --git a/Tools/c-analyzer/cpython/ignored.tsv b/Tools/c-analyzer/cpython/ignored.tsv
index 4327a111eed..686f3935d91 100644
--- a/Tools/c-analyzer/cpython/ignored.tsv
+++ b/Tools/c-analyzer/cpython/ignored.tsv
@@ -739,7 +739,6 @@ Modules/expat/xmlrole.c - declClose -
Modules/expat/xmlrole.c - error -
## other
-Modules/grpmodule.c grp_getgrall_impl getgrall_mutex -
Modules/_io/_iomodule.c - _PyIO_Module -
Modules/_sqlite/module.c - _sqlite3module -
Modules/clinic/md5module.c.h _md5_md5 _keywords - |
Sorry, something went wrong.
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Would you mind removing any corresponding variables from ignored.tsv (and/or globals-to-fix.tsv), like the one added in gh-127055? That would help verify that this change is working right.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
Ok, the ignore from Victor's PR has been removed. I'll do a more thorough audit of what needs to get un-ignored when I'm more available later today. |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Hmm, this seems like a bedevere bug. This should still have awaiting changes per Eric's review, not awaiting merge. |
Sorry, something went wrong.
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Did a search, and it looks like no other mutexes need to get un-ignored. We're good to merge. |
Sorry, something went wrong.
|
Merged, thanks. |
Sorry, something went wrong.
As seen with gh-127055, the C analyzer doesn't like static local variables, but it's fine to do so for a PyMutex. If we want to use a similar approach for other libc functions (as mentioned in gh-127081), it would be better to gracefully handle this instead of adding to ignored.tsv every time.