| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
| } | ||
|
|
||
| _PyRuntime.os_fork.parent = (struct _os_fork_parent){0}; | ||
| PyMutex_Unlock(&_PyRuntime.os_fork.mutex); |
There was a problem hiding this comment.
this might need to be done before _PyThreadState_DeleteList above to handle the very silly case of someone forking from a destructor and deadlocking? ("why is that even reasonable to support?" is valid...)
Sorry, something went wrong.
| _PyEval_StartTheWorldAll(&_PyRuntime); | ||
| _PyThreadState_DeleteList(list); | ||
|
|
||
| _PyImport_ReInitLock(tstate->interp); |
There was a problem hiding this comment.
add a comment mentioning which call above is now responsible for doing this.
Sorry, something went wrong.
| for (PyInterpreterState *interp = runtime->interpreters.head; | ||
| interp != NULL; interp = interp->next) | ||
| { | ||
| _PyImport_ReInitLock(interp, parent); |
There was a problem hiding this comment.
why is this only being done when the GIL is disabled instead of always as it was in the past?
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
gh-126692 took care of one situation where we were assuming the thread ID did not change across fork. However, there is at least one other, in PyOS_AfterFork_Child(). This PR addresses that case along with making the parent's thread ID available to the child.
Here's a breakdown:
I've also moved the _PyImport_ReInitLock() call from PyOS_AfterFork_Child() to _PyRuntimeState_ReInitThreads(), to be more consistent about where we reinitialize locks after forking. If there are any objections, I don't mind dropping that part.
One motivation I have here is that I'd like to use a _PyRecursiveMutex elsewhere and need to be able to correctly reinitialize after forking. That requires knowing the parent's thread ID, to decide if the forking thread held the lock or not. (This wasn't a problem for the import lock, which is a _PyRecursiveMutex, since we always acquire and hold that lock while forking.)
@gpshead, I'd be particularly interested in your thoughts on this.